Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WOFF: Compress & write the font tables in the same order as the origi… #2524

Merged
merged 1 commit into from Oct 18, 2015

Conversation

fred-wang
Copy link
Contributor

…nal sfnt font so that the checkSumAdjustment does not change when the font is decompressed again. Also add a Python test to verify that the WOFF files generated by fontforge are valid. #926

…nal sfnt font so that the checkSumAdjustment does not change when the font is decompressed again. Also add a Python test to verify that the WOFF files generated by fontforge are valid. fontforge#926
@fred-wang
Copy link
Contributor Author

The relevant quotation from http://www.w3.org/TR/WOFF/:

Font tables in WOFF files MUST be stored in the same order as the well-formed input font. The table order is implied by offset values in the table directory; sorting table directory entries into ascending offset value order produces a list of entries in an order equivalent to that of the font tables.

@frank-trampe
Copy link
Contributor

It looks good.

frank-trampe added a commit that referenced this pull request Oct 18, 2015
WOFF: Compress & write the font tables in the same order as the origi…
@frank-trampe frank-trampe merged commit 746280e into fontforge:master Oct 18, 2015
@fred-wang
Copy link
Contributor Author

Thanks! I guess #926 can also be closed, unless there are reasons why checkSumAdjustment can be invalid other than wrong table ordering.

@jtanx
Copy link
Contributor

jtanx commented Sep 6, 2016

So, after looking at #2762, I've found that the added test doesn't work on Python 3 - which all FF unit tests should conform to. Travis wasn't picking this up, because test926.py wasn't added to EXTRA_DIST in Makefile.am so the test was being skipped.

gioele pushed a commit to gioele/fontforge that referenced this pull request Sep 10, 2016
@fred-wang fred-wang deleted the issue-926bis branch June 5, 2018 09:30
Omnikron13 pushed a commit to Omnikron13/fontforge that referenced this pull request May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants