Glyph renaming #524
Closed
Glyph renaming #524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SFGlyphRenameFixup() is too smart that it will, when renaming “f”, it will search for glyphs that has an “f” component, e.g. “f_f” or “f_f_i” and rename the component as well. The desirability of this is questionable, but for now I added a boolean flag to control this and disable it in Python while keeping the GUI behaviour unchanged. Commits / fc92548, see issue 523 "Remove the auto glyph renaming feature."
These things can get forgotten later - better highlight a note.
|
Doesn't compile for me: That should be easy to fix (just change the prototype in the header file), and I don't mind doing so myself. I'm not sure if there's an easy way for me to add commits to an existing pull request that is in someone else's space. Should I make a branch of my own in mskala/fontforge? Should I create a branch in fontforge/fontforge, commit to that, and then file a pull request for merging it to the master? What's the protocol? |
ghost
mentioned this pull request
|
See my suggested patch #532. Is it okay to close this one? |
|
Yes I think so |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Khaled has this solution. Please see if it fits what you are looking for.
If yes, please merge.