Fix lingering processes on shutdown and PyInstaller failing to remove its temporary directory - #178
Merged
Conversation
Added serverProcess.join(timeout=1) after SIGINT to allow the child process a chance to exit cleanly. Prevents Python from hanging during interpreter exit if the child process doesn't terminate right away.
Member
Author
|
@sintfar I will credit you as "sintfar" in the CHANGELOG and CONTRIBUTORS list (in the main repo), unless you prefer to provide a display name. thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #176.
The main change/fix was kindly contributed by @sintfar. Their description:
Some build fixes were added by me:
psutilsomehow broke the macOS universal binary merge stuff.