js split by simoncozens · Pull Request #224 · fontra/fontra-rcjk

simoncozens · 2025-02-28T11:07:50Z

Correct paths
Add missing build hook
Oops, missing files

justvanrossum · 2025-02-28T13:41:20Z

I get the same install failure as the CI when trying to pip install this locally.

simoncozens · 2025-02-28T15:09:17Z

Yep, I need to update the URLs.

justvanrossum · 2025-03-03T09:47:49Z

Any chance you can get this to work today? I'd really like to merge both this and the main PR.

simoncozens · 2025-03-03T11:09:54Z

I will get this working for test purposes, but the JS dependencies will need to be adjusted once again when the Fontra js-split PR is merged.

justvanrossum · 2025-03-03T13:21:40Z

This works, thanks!

So, after the main js-split merge, we need to remove the js-split-2 branch from the gitpkg URLs, right?

I see "integrity" hashes in package-lock.json. Do these get invalidated after each push to the associated repo? Or how does this affect the management of the projects? Does dependabot pick these up?

justvanrossum · 2025-03-03T14:17:51Z

I'm locally trying to edit the gitpkg URLs in package.json, but when I then run npm install and npm run bundle, the latter fails:

> bundle
> webpack --config webpack.config.cjs --mode production

assets by status 7.42 KiB [cached] 3 assets
Entrypoint __bundler-plugin-entry__landing = landing.html landing.css
Entrypoint landing = landing.b209169f8a8943e44146.js
runtime modules 670 bytes 3 modules
orphan modules 821 bytes [orphan] 1 module
cacheable modules 8.46 KiB
  ./src-js/projectmanager-rcjk/landing.html 2.09 KiB [built] [code generated]
  ./src-js/projectmanager-rcjk/src/landing.js + 1 modules 2.17 KiB [built] [code generated]
  ./node_modules/@fontra/projectmanager-filesystem/assets/landing.css 4.2 KiB [built] [code generated]

ERROR in ./node_modules/@fontra/projectmanager-filesystem/src/landing.js 1:0-54
Module not found: Error: Can't resolve '@fontra/core/backend-api.js' in '/Users/just/code/git/BlackFoundry/fontra-rcjk/node_modules/@fontra/projectmanager-filesystem/src'
 @ ./src-js/projectmanager-rcjk/src/landing.js 2:0-82 5:2-20

ERROR in ./node_modules/@fontra/projectmanager-filesystem/src/landing.js 2:0-63
Module not found: Error: Can't resolve '@fontra/core/loader-spinner.js' in '/Users/just/code/git/BlackFoundry/fontra-rcjk/node_modules/@fontra/projectmanager-filesystem/src'
 @ ./src-js/projectmanager-rcjk/src/landing.js 2:0-82 5:2-20

ERROR in ./node_modules/@fontra/projectmanager-filesystem/src/landing.js 3:0-40
Module not found: Error: Can't resolve '@fontra/core/theme-settings.js' in '/Users/just/code/git/BlackFoundry/fontra-rcjk/node_modules/@fontra/projectmanager-filesystem/src'
 @ ./src-js/projectmanager-rcjk/src/landing.js 2:0-82 5:2-20

ERROR in ./src-js/projectmanager-rcjk/src/landing.js 1:0-53
Module not found: Error: Can't resolve '@fontra/core/utils.js' in '/Users/just/code/git/BlackFoundry/fontra-rcjk/src-js/projectmanager-rcjk/src'

4 errors have detailed information that is not shown.
Use 'stats.errorDetails: true' resp. '--stats-error-details' to show it.

 HTML Bundler Plugin   ▶▶▶ (webpack 5.97.1) compiled with 4 errors in 161 ms

As usual, I may be doing something wrong or misunderstand something.

simoncozens · 2025-03-03T14:20:04Z

So, after the main js-split merge, we need to remove the js-split-2 branch from the gitpkg URLs, right?

Right, yes.

I'm locally trying to edit the gitpkg URLs in package.json, but when I then run npm install and npm run bundle, the latter fails.

This happened for me; I trashed the package-lock.json and tried again, and it worked.

justvanrossum · 2025-03-03T14:25:28Z

Hm, I did:

diff --git a/src-js/projectmanager-rcjk/package.json b/src-js/projectmanager-rcjk/package.json
index b579a75..7e533cd 100644
--- a/src-js/projectmanager-rcjk/package.json
+++ b/src-js/projectmanager-rcjk/package.json
@@ -10,7 +10,7 @@
     "projectmanager": "rcjk"
   },
   "dependencies": {
-    "@fontra/core": "https://gitpkg.vercel.app/googlefonts/fontra/src-js/fontra-core?js-split-2",
-    "@fontra/projectmanager-filesystem": "https://gitpkg.vercel.app/googlefonts/fontra/src-js/projectmanager-filesystem?js-split-2"
+    "@fontra/core": "https://gitpkg.vercel.app/googlefonts/fontra/src-js/fontra-core?main",
+    "@fontra/projectmanager-filesystem": "https://gitpkg.vercel.app/googlefonts/fontra/src-js/projectmanager-filesystem?main"
   }
 }

Then

rm package-lock.json
npm install
npm run bundle

But keep getting the same error.

(Does gitpkg.vercel.app update instanteneous, or could there be a delay, and it may still see the pre-split version?)

justvanrossum · 2025-03-03T14:27:33Z

Ah, it does work if I replace the branch with a specific commit.

justvanrossum · 2025-03-03T14:28:45Z

This would be the total diff after npm install:

diff --git a/package-lock.json b/package-lock.json
index 731e711..ef363bb 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -33,8 +33,8 @@
       }
     },
     "node_modules/@fontra/core": {
-      "resolved": "https://gitpkg.vercel.app/googlefonts/fontra/src-js/fontra-core?js-split-2",
-      "integrity": "sha512-ple17lpINSpmaQoMg5/MsbhknJJYVXp1Num+gNIqwUO7nwLs6naqUEEGY2RKgxkmekdPiG9wwPgXAbmLCj5FMw==",
+      "resolved": "https://gitpkg.vercel.app/googlefonts/fontra/src-js/fontra-core?c604e72ad7c7b05b24848c50d253016f6e091c6a",
+      "integrity": "sha512-DOucz16A+mQIWS268snlqtwkkC1cxRjEntdssRacSd8ovozp2bbOqyH2VCD9Bl56FmRI3egLGthMzR9ZH3ikiw==",
       "dependencies": {
         "@fontra/core": "file:",
         "bezier-js": "^6.1.4",
@@ -45,8 +45,8 @@
     },
     "node_modules/@fontra/projectmanager-filesystem": {
       "version": "0.0.1",
-      "resolved": "https://gitpkg.vercel.app/googlefonts/fontra/src-js/projectmanager-filesystem?js-split-2",
-      "integrity": "sha512-kAjovyBM980oeAovQVHmjq6Nh1R2jklsql6ukRn+KS9tzXb/TMDvULHmMK6tjxNu0rMbo+hy4Q9R+qOrvPsBsg=="
+      "resolved": "https://gitpkg.vercel.app/googlefonts/fontra/src-js/projectmanager-filesystem?c604e72ad7c7b05b24848c50d253016f6e091c6a",
+      "integrity": "sha512-r3DI0zSI1WwDiyqE42+gBDuPtrMIeybZ8UgIKAWJs8LQPW4R4rDn238vJ5tZevNcRHufYG2aP5UGENblJ4iLRg=="
     },
     "node_modules/@fontra/projectmanager-rcjk": {
       "resolved": "src-js/projectmanager-rcjk",
@@ -5189,8 +5189,8 @@
       "name": "@fontra/projectmanager-rcjk",
       "version": "0.0.1",
       "dependencies": {
-        "@fontra/core": "https://gitpkg.vercel.app/googlefonts/fontra/src-js/fontra-core?js-split-2",
-        "@fontra/projectmanager-filesystem": "https://gitpkg.vercel.app/googlefonts/fontra/src-js/projectmanager-filesystem?js-split-2"
+        "@fontra/core": "https://gitpkg.vercel.app/googlefonts/fontra/src-js/fontra-core?c604e72ad7c7b05b24848c50d253016f6e091c6a",
+        "@fontra/projectmanager-filesystem": "https://gitpkg.vercel.app/googlefonts/fontra/src-js/projectmanager-filesystem?c604e72ad7c7b05b24848c50d253016f6e091c6a"
       }
     }
   }
diff --git a/src-js/projectmanager-rcjk/package.json b/src-js/projectmanager-rcjk/package.json
index b579a75..3fdbe54 100644
--- a/src-js/projectmanager-rcjk/package.json
+++ b/src-js/projectmanager-rcjk/package.json
@@ -10,7 +10,7 @@
     "projectmanager": "rcjk"
   },
   "dependencies": {
-    "@fontra/core": "https://gitpkg.vercel.app/googlefonts/fontra/src-js/fontra-core?js-split-2",
-    "@fontra/projectmanager-filesystem": "https://gitpkg.vercel.app/googlefonts/fontra/src-js/projectmanager-filesystem?js-split-2"
+    "@fontra/core": "https://gitpkg.vercel.app/googlefonts/fontra/src-js/fontra-core?c604e72ad7c7b05b24848c50d253016f6e091c6a",
+    "@fontra/projectmanager-filesystem": "https://gitpkg.vercel.app/googlefonts/fontra/src-js/projectmanager-filesystem?c604e72ad7c7b05b24848c50d253016f6e091c6a"
   }
 }

justvanrossum · 2025-03-03T14:30:16Z

The question remains on how do we best maintain this.

justvanrossum · 2025-03-03T14:31:06Z

(Let me know if you want me to commit it in this state.)

simoncozens · 2025-03-03T14:36:17Z

I think https://gitpkg.vercel.app/googlefonts/fontra/src-js/fontra-core?main would work.

justvanrossum · 2025-03-03T14:39:32Z

I think https://gitpkg.vercel.app/googlefonts/fontra/src-js/fontra-core?main would work.

Except it didn't, and doesn't :( Hence my question about possible delay in gitpkg updating.

justvanrossum · 2025-03-03T15:04:15Z

So what do you recommend we'd do? I want to merge this PR today, too.

justvanrossum · 2025-03-03T17:01:39Z

It seems that the redirect to login (if not logged in) no longer works. Not sure if that is here or in the main fontra repo.

simoncozens · 2025-03-03T17:29:19Z

I think I have a fix, just testing it.

simoncozens · 2025-03-03T17:48:28Z

OK, there we go, npm was going mad about these packages not having proper versions, and npm install --prefer-dedupe (for some reason) fixes it.

justvanrossum · 2025-03-03T18:46:13Z

Works for me. However, if I remove the --prefer-dedupe option, it still works. So I wonder again if we were fooled by a delayed update by gitpkg.vercel?

justvanrossum · 2025-03-03T18:46:30Z

Other than that, is this good to go for you?

justvanrossum · 2025-03-03T18:47:01Z

It seems that the redirect to login (if not logged in) no longer works. Not sure if that is here or in the main fontra repo.

Not here, but in the main repo: https://github.com/googlefonts/fontra/issues/2074

simoncozens · 2025-03-03T19:15:13Z

Works for me. However, if I remove the --prefer-dedupe option, it still works. So I wonder again if we were fooled by a delayed update by gitpkg.vercel?

No, we resolved the dependency problem and put the resolution into package.json so it doesn't need to think about it any more.

simoncozens · 2025-03-03T19:15:35Z

Other than that, is this good to go for you?

Fine for me, I'll fix the redirect problem separately.

justvanrossum · 2025-03-03T20:32:58Z

No, we resolved the dependency problem and put the resolution into package.json so it doesn't need to think about it any more.

The fact remains that if I remove the --prefer-dedupe option, and delete the package-lock.json file, pip install -e . just works, and I see no diff in package-lock.json.

justvanrossum · 2025-03-03T20:37:34Z

Urgh, now the main branch fails, despite the PR was all green.

simoncozens · 2025-03-03T21:06:25Z

Will fix in the morning.

justvanrossum · 2025-03-03T21:08:07Z

I'm pretty sure this is what's happening:

I see "integrity" hashes in package-lock.json. Do these get invalidated after each push to the associated repo?

"Yes".

So, how can we organize this better?

simoncozens added 3 commits February 28, 2025 11:07

Correct paths

eb06f46

Add missing build hook

b753461

Oops, missing files

385a7c7

justvanrossum mentioned this pull request Feb 28, 2025

Split Javascript and Python fontra/fontra#2053

Merged

simoncozens force-pushed the js-split branch from 916998d to 3deb18f Compare March 3, 2025 13:05

Use main fontra repo and --prefer-dedupe

2a8f5ef

simoncozens force-pushed the js-split branch from 3deb18f to 2a8f5ef Compare March 3, 2025 17:39

Remove unused imports

231dd4b

justvanrossum marked this pull request as ready for review March 3, 2025 20:33

justvanrossum merged commit 5eb4c3a into main Mar 3, 2025

justvanrossum deleted the js-split branch March 3, 2025 20:33

Uh oh!

Conversation

simoncozens commented Feb 28, 2025

Uh oh!

justvanrossum commented Feb 28, 2025

Uh oh!

simoncozens commented Feb 28, 2025

Uh oh!

justvanrossum commented Mar 3, 2025

Uh oh!

simoncozens commented Mar 3, 2025

Uh oh!

justvanrossum commented Mar 3, 2025

Uh oh!

justvanrossum commented Mar 3, 2025

Uh oh!

simoncozens commented Mar 3, 2025

Uh oh!

justvanrossum commented Mar 3, 2025

Uh oh!

justvanrossum commented Mar 3, 2025

Uh oh!

justvanrossum commented Mar 3, 2025

Uh oh!

justvanrossum commented Mar 3, 2025

Uh oh!

justvanrossum commented Mar 3, 2025

Uh oh!

simoncozens commented Mar 3, 2025

Uh oh!

justvanrossum commented Mar 3, 2025

Uh oh!

justvanrossum commented Mar 3, 2025

Uh oh!

justvanrossum commented Mar 3, 2025

Uh oh!

simoncozens commented Mar 3, 2025

Uh oh!

simoncozens commented Mar 3, 2025

Uh oh!

justvanrossum commented Mar 3, 2025

Uh oh!

justvanrossum commented Mar 3, 2025

Uh oh!

justvanrossum commented Mar 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

simoncozens commented Mar 3, 2025

Uh oh!

simoncozens commented Mar 3, 2025

Uh oh!

justvanrossum commented Mar 3, 2025

Uh oh!

justvanrossum commented Mar 3, 2025

Uh oh!

simoncozens commented Mar 3, 2025

Uh oh!

justvanrossum commented Mar 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

justvanrossum commented Mar 3, 2025 •

edited

Loading