Skip to content

Font Info menu items don't correctly link #1941

Description

@justvanrossum

This is currently not working on RCJK.

It's a regression caused by https://github.com/googlefonts/fontra/pull/1925.

The bug is in this line:

https://github.com/googlefonts/fontra/blob/944b81abeac6361d234565b3807e854ea07fef07/src/fontra/client/core/fontra-menus.js#L169

This used to be:

    url.pathname = url.pathname.replace("/editor/", "/fontinfo/");

I think it should be replaced with

    url.pathname = url.pathname.replace(/^\/[A-Za-z-]+\/, "/fontinfo/");

edit, nah, it should be replaced with split/join on /.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions