Skip to content

Select next/previous glyph - #1706

Merged
justvanrossum merged 11 commits into
mainfrom
issue-1703-next-previous-glyph
Nov 13, 2024
Merged

Select next/previous glyph#1706
justvanrossum merged 11 commits into
mainfrom
issue-1703-next-previous-glyph

Conversation

@ollimeier

Copy link
Copy Markdown
Contributor

Fixes #1703

@justvanrossum

Copy link
Copy Markdown
Member

The order of the glyphMap does not really have a meaning, and is more or less undefined, so what this ends up doing is mostly accidental, even if it may happen to work somewhat. It may depend on how the backend prepares the list.

It is notably not the same order as what you see in the search list, which is sorted according to certain criteria, also taking the code point(s) into account.

So, as it stands, I am not in favor of this feature, and it requires more thought and design to properly define what it should do in the first place.

@ollimeier

Copy link
Copy Markdown
Contributor Author

Some notes from todays meeting:

Should the sorting be equal to the 'Glyph Search' sidebar?

  • if you search for 'A' -> should it go through the selection only?
  • future ideas for 'Search Glyph': search for categories like scripts. eg only show Cyrillic glyphs
    -> should next/previous glyph then also go through this category only?

Please check if the shortcuts commandKey + arrowLeft/Right work for Firefox and Safari also.

@ollimeier

Copy link
Copy Markdown
Contributor Author

@justvanrossum I checked the shortcuts commandKey + arrowLeft/Right in Chrome, Firefox and Safari and it works in all browsers.

@ollimeier
ollimeier marked this pull request as draft October 10, 2024 10:39
@ollimeier

Copy link
Copy Markdown
Contributor Author

@justvanrossum I have set this PR to 'draft', as I am not sure about the last commit. But I figured out a solution to go through the glyph-order of 'Glyph Search'-sidebar + only the glyphs which are relevant, when the search has been used. Here a short demo:

Screen.Recording.2024-10-10.at.12.36.14.mp4

Comment thread src/fontra/views/editor/panel-glyph-search.js Outdated
@ollimeier
ollimeier marked this pull request as ready for review October 10, 2024 15:20
@ollimeier
ollimeier force-pushed the issue-1703-next-previous-glyph branch from 18cbc0f to a0a66e6 Compare October 31, 2024 09:36
Comment thread src/fontra/client/web-components/glyphs-search.js Outdated
@ollimeier
ollimeier force-pushed the issue-1703-next-previous-glyph branch from d66987e to cfb4e7c Compare November 6, 2024 00:02
Comment thread src/fontra/views/editor/editor.js
@justvanrossum
justvanrossum merged commit 5581020 into main Nov 13, 2024
@justvanrossum
justvanrossum deleted the issue-1703-next-previous-glyph branch November 13, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Next/Previous Glyph

2 participants