Serve Glyph Data as CSV file, implement glyph name / code point helpers in JS - #1900
Merged
Merged
Conversation
…nd api; remove Python implementation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Serve Glyph Data as CSV file, and implement getCodePointFromGlyphName and getSuggestedGlyphName on the client side.
This opens up using this data in the font overview (#1886) for grouping/sorting/finding/etc.
This means we don't depend on glyphsLib anymore at runtime. We do need it to build the CSV file, and the test suite checks whether the file is stale. Not sure how to declare this build/test glyphLib dependency, so I'll keep the dependency for now.