Skip to content

Fix tooltips in sidebars #2050 - #2056

Merged
justvanrossum merged 2 commits into
fontra:mainfrom
giovanniTramonto:fix-sidebar-cropping
Feb 27, 2025
Merged

Fix tooltips in sidebars #2050#2056
justvanrossum merged 2 commits into
fontra:mainfrom
giovanniTramonto:fix-sidebar-cropping

Conversation

@giovanniTramonto

@giovanniTramonto giovanniTramonto commented Feb 26, 2025

Copy link
Copy Markdown
Contributor

This fixes https://github.com/googlefonts/fontra/issues/2050, both issues.

Tooltip line-height. The change in googlefonts/fontra@ad2cb59 was related to an issue with icons while scrolling, because of their line-height. In this case tooltip inherited the 0 line-height.

Tooltip cropping. This was was caused in a4edd57

@justvanrossum

Copy link
Copy Markdown
Member

Please mention the bug(s) in the description so that this PR is linked to them. For example "This fixes #NNNN and fixes #MMMM".

@giovanniTramonto

Copy link
Copy Markdown
Contributor Author

Please mention the bug(s) in the description so that this PR is linked to them. For example "This fixes #NNNN and fixes #MMMM".

@justvanrossum OK adjusted above 👆

@justvanrossum

Copy link
Copy Markdown
Member

Thank you!

@justvanrossum
justvanrossum merged commit 1a01bda into fontra:main Feb 27, 2025
@justvanrossum

Copy link
Copy Markdown
Member

Actually, you need to literally write "fixes #NNNN" (there are some variations), or the linkage does not happen. You can tell by going to the issue and see whether it is linked to a PR. I edited now after the fact.

@giovanniTramonto

Copy link
Copy Markdown
Contributor Author

Actually, you need to literally write "fixes #NNNN" (there are some variations), or the linkage does not happen. You can tell by going to the issue and see whether it is linked to a PR. I edited now after the fact.

Ah OK, yes I see your point. Thanks. Will consider for future MRs

@giovanniTramonto
giovanniTramonto deleted the fix-sidebar-cropping branch February 27, 2025 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Tooltip] Too small padding for tooltips in sidebars

2 participants