Skip to content

Don’t set context.direction to undefined - #2174

Merged
justvanrossum merged 1 commit into
fontra:mainfrom
aliftype:issue2171
Jun 4, 2025
Merged

justvanrossum merged 1 commit into
fontra:mainfrom
aliftype:issue2171

Conversation

@khaledhosny

@khaledhosny khaledhosny commented Jun 4, 2025 •

Copy link
Copy Markdown
Contributor

If guessGlyphPlaceholderString() returns undefined for direction, keep context.direction unchanged.

Fixes https://github.com/googlefonts/fontra/issues/2171

If guessGlyphPlaceholderString() returns undefined for direction, keep
context.direction unchanged.

Fixes https://github.com/googlefonts/fontra/issues/2171
@khaledhosny khaledhosny changed the title Fix fallback for undefined direction from guessGlyphPlaceholderString() Don’t set context.direction to undefined Jun 4, 2025

@justvanrossum justvanrossum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, thank you!

@justvanrossum
justvanrossum merged commit 7aaa5ee into fontra:main Jun 4, 2025
@khaledhosny
khaledhosny deleted the issue2171 branch May 2, 2026 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New warning in Chrome: The provided value 'undefined' is not a valid enum value of type CanvasDirection.

2 participants