Skip to content

Allows kerning jumps from 5 to 5 units - #2205

Merged
justvanrossum merged 9 commits into
mainfrom
Kerning_jumps_five_to_five
Jul 3, 2025
Merged

Allows kerning jumps from 5 to 5 units#2205
justvanrossum merged 9 commits into
mainfrom
Kerning_jumps_five_to_five

Conversation

@GaetanBaehr

Copy link
Copy Markdown
Collaborator

A pull request to allows jumping from 5 to 5 units when hold alt key and dragging the selector, or press arrows keys

@GaetanBaehr
GaetanBaehr requested a review from justvanrossum July 3, 2025 09:00
@GaetanBaehr GaetanBaehr changed the title Update edit-tools-kerning.js Allows kerning jumps from 5 to 5 units Jul 3, 2025
Comment thread src-js/views-editor/src/edit-tools-kerning.js Outdated
return;
}
if (event.shiftKey) {
if (event.altKey) {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to define something for the combination of alt and shift? If you'd leave out the "else" that would be "50", for what it's worth...

@GaetanBaehr

Copy link
Copy Markdown
Collaborator Author

@justvanrossum I reformated with an external _factor function to handle the 3 situations: alt / shift / alt+shift
and now the shift works when dragging the selector.

Comment thread src-js/views-editor/src/edit-tools-kerning.js Outdated
Comment thread src-js/views-editor/src/edit-tools-kerning.js Outdated
@justvanrossum

Copy link
Copy Markdown
Member

I made a couple of minor tweaks, otherwise this is done. Thank you!

@justvanrossum
justvanrossum merged commit 3411ecb into main Jul 3, 2025
5 checks passed
@justvanrossum
justvanrossum deleted the Kerning_jumps_five_to_five branch July 3, 2025 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants