Skip to content

Implement Sidebearing Tool - #2216

Merged
justvanrossum merged 112 commits into
mainfrom
sidebearingtool-issue-2213
Jul 14, 2025
Merged

Implement Sidebearing Tool#2216
justvanrossum merged 112 commits into
mainfrom
sidebearingtool-issue-2213

Conversation

@justvanrossum

@justvanrossum justvanrossum commented Jul 10, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

This fixes #2213.

  • Implement Sidebearing tool
  • The Kerning tool is now a subtool, the sidebearing tool is the main one

Changes for the Kerning tool:

  • Different cursor
  • Tab/shift-tab to go to the next/previous kerning pair

@justvanrossum
We must update the canvas when switching tools
f301b87
@justvanrossum
Add stub for sidebearing tool
05648ae
@justvanrossum
Add stub for handleDrag
b6737d0
@justvanrossum
Factor out line iteration, as we'll need that for sidebearings, too
6a6daf3
@justvanrossum
One line is enough, no need for iteration
fb15f00
@justvanrossum
Remove unused size argument
f27e507
@justvanrossum
Implement sidebearingAtPoint
b38e311
@justvanrossum
Start detecting sidebearing hover
c5fdc12
@justvanrossum
Differentiate between sb hit and courser 'side' hit
6a7ab51
@justvanrossum
Also check for inside-hull-ness
64a43bd
@justvanrossum
Set cursor based on hover
dfd1b31
@justvanrossum
Simplify
b18d012
@justvanrossum
Whitespace
055f0eb
@justvanrossum
Use ew-resize cursor for kerning, too
95d8f2f
@justvanrossum
Rename module
611bfb9
@justvanrossum
Some refactoring using common base classes; stub for SidebearingHandle
d4d2ec1
@justvanrossum
More refactoring
114c05d
@justvanrossum
More refactoring
61aa5b7
@justvanrossum
More refactoring
acdd564
@justvanrossum
More refactoring
f3330ef
@justvanrossum
More refactoring
67c3989
@justvanrossum
More refactoring, renaming
60c9687
@justvanrossum
Remove unused line
71d6dc8
@justvanrossum
Move undo to base class
8b26520
@justvanrossum
Bang bang boolean
46139a6
@justvanrossum
Just select the custom element, no need for a class
6175939
@justvanrossum
Stub+fix SidbearingHandle class
eb87001
@justvanrossum
Style sidebearing elements, set values
585fddd
@justvanrossum
Refactor, start with selecting sidebearing handles
ab0c0b6
@justvanrossum
Fiddle with styling, cursors
a5cd0bb
@justvanrossum
Pass event around to inner loop, so we can respond to modifier keys
cc1410f
@justvanrossum
I need to give the alt key a different meaning for sidebearings, so m…
f24c551 
…ake sb step and kern step different, fwiw.
@justvanrossum
When control-clicking/right-clicking on a tool with subtools, do not …
431a4e3 
…activate the top tool first. This prevents odd behavior with sb/kern tool, which would otherwise turn on kerning too early
@justvanrossum
Refactor step value as overridable method
21a3206
@justvanrossum
Implement alt-sidebearing behavior
8238733
@justvanrossum
Use braces in switch branches
692fb5d
@justvanrossum
Improve clamping behavior for LR drag
0762cc1
@justvanrossum
Position the individual handles instead of the container, that gives …
fef5897 
…the desired result even when xAdvance is 0
@justvanrossum
Fix during-drag-alt-key toggle
18e43d0
@justvanrossum
Add hack to ignore modifier keys for space key clean view shortcut
05b691f
@justvanrossum
Make behavior saner when the shape is not contained between 0..xAdvance
2f5420c
@justvanrossum
On click/drag, fetch the hovered metric fresh, as in the context of u…
c5c2c1f 
…ndo, it may not be reliable
@justvanrossum
No need for stored arrow func
48b8278
@justvanrossum
For line box, take the min/max of metrics bounds and shape bounds
e2e7547
@justvanrossum
Don't error when arrow-key on empty selection
15608ff
@justvanrossum
Fix undo scroll pinpoint for sb edit
953ac9b
@justvanrossum
Ensure the dragged handle is on top, aka last in the selected handles…
42ba85f 
… list
@justvanrossum
Implement tab key prev/next behavior for sb
da6a6b8
@justvanrossum
Implement tab next/prev for kern pairs
ea5dc11
@justvanrossum
Simplify with do/while
2229330
@justvanrossum
let -> const
ef71a39
@justvanrossum
Use more general glyphAtPoint to find direct glyph hit. lineAtPoint m…
cdf38c4 
…isses clicks above or below the metrics box
@justvanrossum
Parametrize handle colors, color sb according to pos/neg
acbb024
@justvanrossum
Fiddle with vertical position of handles
9529c9d
@justvanrossum
Implement 'Sidebearings (tool)' layer, by refactoring the mini-sidebe…
b1783f4 
…aring visualisation, and move it to the tool module
@justvanrossum justvanrossum changed the title Implement Sidebear Tool Implement Sidebearing Tool Jul 14, 2025
@justvanrossum
justvanrossum merged commit 56f9bd0 into main Jul 14, 2025
5 checks passed
@justvanrossum
justvanrossum deleted the sidebearingtool-issue-2213 branch July 14, 2025 12:30
@justvanrossum justvanrossum mentioned this pull request Jul 14, 2025
Closed
@justvanrossum justvanrossum mentioned this pull request Dec 16, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implement interactive sidebearing editing tool

1 participant

@justvanrossum