[designspace] Fix the interpretation of the "layer" source attribute - #2315
Merged
Conversation
…e rules: if the source layer attr is present, the source is sparse
justvanrossum
force-pushed
the
ds-sparse-sources-issue-2314
branch
2 times, most recently
from
November 21, 2025 15:12
e54c558 to
f5caeab
Compare
…to a (not sparse) dense source
justvanrossum
force-pushed
the
ds-sparse-sources-issue-2314
branch
from
November 21, 2025 15:19
f5caeab to
196ecf0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #2314
Make the interpretation of the
<source>"layer" attribute match fontmake, ie. if it is present, the source is considered "sparse". Previously, Fontra only considered designspace source sparse if the layer attribute differed from the default layer name. Subtle but cricial difference.Additionally, this allows us to finally expose the "is sparse" flag as a checkbox in the Font Sources panel.