Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes merge bug when VF source have no blends or no marking glyphs in any charstrings. #1642

Merged
merged 5 commits into from Jun 17, 2019

Conversation

Projects
None yet
2 participants
@readroberts
Copy link
Collaborator

commented Jun 12, 2019

Fixes issue: "KeyError in varLib.cff.merge_PrivateDicts #1632".

readroberts added some commits Jun 12, 2019

[varLib.cff] Fix merging bug when there are no blends or marking glyphs.
If the CFF2 VF has no blends, or no marking glyphs, the default variation table does not get built; this can be needed later for the PrivateDict.

@readroberts readroberts requested review from anthrotype and behdad Jun 13, 2019

@anthrotype
Copy link
Member

left a comment

LGTM, with comment

Show resolved Hide resolved Lib/fontTools/varLib/cff.py Outdated
Show resolved Hide resolved Lib/fontTools/varLib/cff.py Outdated
Show resolved Hide resolved Lib/fontTools/varLib/cff.py Outdated

anthrotype added some commits Jun 14, 2019

@anthrotype anthrotype merged commit eda353c into master Jun 17, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@anthrotype anthrotype deleted the CFF2-fixes branch Jun 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.