New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Clipper 6.4.2 #11

Merged
merged 1 commit into from Jan 6, 2018

Conversation

Projects
None yet
4 participants
@athos-ribeiro
Contributor

athos-ribeiro commented Oct 22, 2017

There were no changes in the ABI of the functions wrapped in pyclipper,
hence no major changes were performed here. Clipper.Execute now fails if
called after clear, and this brought changes to the test suite.

  • Update embedded Clipper version
  • Remove execution permissions from Clipper files
  • Closes #10

sha256:
pyclipper/clipper.cpp:
5c642a3668311701f72572443aa42c1a981edb037298efc015166d9d90be0755
pyclipper/clipper.hpp:
734eba9dc9d399089b2b467017074bd24728a1b9e64c7429e827806ed10e54cc

Use Clipper 6.4.2
There were no changes in the ABI of the functions wrapped in pyclipper,
hence no major changes were performed here. Clipper.Execute now fails if
called after clear, and this brought changes to the test suite.

* Update embedded Clipper version
* Remove execution permissions from Clipper files
* Closes #10

sha256:
pyclipper/clipper.cpp:
5c642a3668311701f72572443aa42c1a981edb037298efc015166d9d90be0755
pyclipper/clipper.hpp:
734eba9dc9d399089b2b467017074bd24728a1b9e64c7429e827806ed10e54cc
solution = self.pc.Execute(*self.default_args)
self.assertEqual(len(solution), 0)
with self.assertRaises(pyclipper.ClipperException):
solution = self.pc.Execute(*self.default_args)

This comment has been minimized.

@anthrotype

anthrotype Oct 23, 2017

Member

Also the return value is unused, so you could just call Execute without saving solution, but it’s ok.

@anthrotype

anthrotype Oct 23, 2017

Member

Also the return value is unused, so you could just call Execute without saving solution, but it’s ok.

@QuLogic

This comment has been minimized.

Show comment
Hide comment
@QuLogic

QuLogic commented Dec 29, 2017

Ping?

@anthrotype

This comment has been minimized.

Show comment
Hide comment
@anthrotype

anthrotype Jan 3, 2018

Member

@greginvm I'm going to merge this and cut a new release. Is that ok with you?

Member

anthrotype commented Jan 3, 2018

@greginvm I'm going to merge this and cut a new release. Is that ok with you?

@anthrotype anthrotype merged commit 3b4ee0a into fonttools:master Jan 6, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@anthrotype

This comment has been minimized.

Show comment
Hide comment
@anthrotype

anthrotype Jan 6, 2018

Member

the github repository short description in the main page still says 6.2.1. only owner @greginvm can modify that

Member

anthrotype commented Jan 6, 2018

the github repository short description in the main page still says 6.2.1. only owner @greginvm can modify that

@greginvm

This comment has been minimized.

Show comment
Hide comment
@greginvm

greginvm Jan 9, 2018

Contributor

@anthrotype Sorry for being late. Great job! 👍

I currently do not have time to work on this and I also do not use this library anymore so if you want to push something just go. No need to ask me for permissions. In case you need some access just let me know. If you want we can transfer the repo to you.

Contributor

greginvm commented Jan 9, 2018

@anthrotype Sorry for being late. Great job! 👍

I currently do not have time to work on this and I also do not use this library anymore so if you want to push something just go. No need to ask me for permissions. In case you need some access just let me know. If you want we can transfer the repo to you.

@anthrotype

This comment has been minimized.

Show comment
Hide comment
@anthrotype

anthrotype Jan 9, 2018

Member

@greginvm oh, sorry to hear that... You could transfer it to https://github.com/fonttools organization. I will give you back write access to the repo in case you change you're mind :)
Thank you for your work and generosity!

Member

anthrotype commented Jan 9, 2018

@greginvm oh, sorry to hear that... You could transfer it to https://github.com/fonttools organization. I will give you back write access to the repo in case you change you're mind :)
Thank you for your work and generosity!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment