Allow editing recurring task groups #152

Closed
wvengen opened this Issue Jul 11, 2013 · 14 comments

Projects

None yet

2 participants

@wvengen
Member
wvengen commented Jul 11, 2013

When a recurring task is edited, a copy is made to a non-recurring task so that the exception can be edited. It would be useful to be able to edit the recurring task properties as well.

See also #142 and #151.

@wvengen
Member
wvengen commented Mar 8, 2014

For reference, it may be an idea to use schedule_fu, or ice_cube+recurring_select at some point.

@wvengen wvengen modified the milestone: 4.3 Oct 10, 2014
@wvengen wvengen modified the milestone: 4.4, 4.3 Dec 11, 2014
@wvengen
Member
wvengen commented Apr 17, 2015

@robwa would you like to look at this issue? I've tried to give it a shot, but I'm not really sure how to do this properly.

@robwa
robwa commented Apr 19, 2015

I will try to produce some code. It will take some days or maybe even weeks, but I won't forget it.

@wvengen
Member
wvengen commented Apr 19, 2015

Thank you!
And I'll have patience - whether in time for the 4.4 release I'd like to do within some weeks, or not.

@robwa
robwa commented May 1, 2015

Please have a look at the feature branch. For me it works.

'Responsible Users' and 'Done?' are not updated as it wouldn't make sense to me.

Maybe we should adjust user interface a little bit (messages, button label)?

@wvengen
Member
wvengen commented May 2, 2015

Thanks! I agree that users and done don't need to be updated. Perhaps done tasks should not be touched?

I'm pondering whether it would be clearer to change all repeating tasks after the task edited (similar to existing calendar applications). What do you think?

@robwa
robwa commented May 2, 2015

Perhaps done tasks should not be touched?

As far as I remember tasks are excluded from the group when marked as done (as they are at any modification).

I'm pondering whether it would be clearer to change all repeating tasks after the task edited (similar to existing calendar applications).

I'm not familiar with existing applications. What would be the workflow for the user? Could you outline it?

@wvengen
Member
wvengen commented May 8, 2015

As far as I remember tasks are excluded from the group when marked as done (as they are at any modification).

Ah, of course :)

What would be the workflow for the user?

Looking at some more apps, I find that the most important options are "change only this event" and "change all events in the series" (Android calendar app's wording), with "Change this and all future events" as well for some apps. I guess current functionality is perfect!

@wvengen
Member
wvengen commented May 8, 2015

In-line with the current UI, we could add a button "Edit task and subsequent".
foodsoft_-show_task-_2015-05-08_13 19 06

But it becomes a bit crowded.
foodsoft_-show_task-_2015-05-08_13 31 50

@wvengen
Member
wvengen commented May 8, 2015

Perhaps
foodsoft_-show_task-_2015-05-08_13 34 44

The delete recurring confirmation dialog gives explanation, and we could use a flash message in the edit and edit recurring screen to explain what happens.

@wvengen
Member
wvengen commented May 8, 2015

(looking twice, I'd prefer the recurring icon before the text)

@wvengen
Member
wvengen commented May 8, 2015

I've been so free as to commit this in a00e7c9
Do you like the change?

@robwa
robwa commented May 8, 2015

Thank you! I really like the changes.

@wvengen
Member
wvengen commented May 8, 2015

Thanks!

@wvengen wvengen closed this May 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment