Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MapBox version for the “locations” page #2

Open
first-timers bot opened this issue Apr 10, 2019 · 1 comment

Comments

Projects
None yet
1 participant
@first-timers
Copy link

commented Apr 10, 2019

🆕🐥☝ First Timers Only.

This issue is reserved for people who never contributed to Open Source before. We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

About First Timers Only.

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

  • 🙋 Claim this issue: Comment below.

    Once claimed we add you as contributor to this repository.

  • 👌 Accept our invitation to this repository. Once accepted, assign yourself to this issue

  • 📝 Update the file _layouts/location-list.html in the site repository (press the little pen Icon) and edit the line as shown below.

@@ -9,7 +9,7 @@
 include_footer: false
 
 stylesheets:
-  - "https://api.tiles.mapbox.com/mapbox-gl-js/v0.48.0/mapbox-gl.css"
+  - "https://api.tiles.mapbox.com/mapbox-gl-js/v0.53.1/mapbox-gl.css"
 ---
 
 <h2><a href="#list-results" id="list-results-title">List Results</a></h2>
@@ -175,7 +175,7 @@ <h1>Oops! We couldn’t find any matching locations.</h1>
 <!-- Jim’s Google Maps API key -->
 <script src="https://maps.googleapis.com/maps/api/js?key=AIzaSyBP5KxqO9v1sLhXlkrG3vDiDdOJvYLJ0H4"></script>
 
-<script src="https://api.tiles.mapbox.com/mapbox-gl-js/v0.48.0/mapbox-gl.js"></script>
+<script src="https://api.tiles.mapbox.com/mapbox-gl-js/v0.53.1/mapbox-gl.js"></script>
 
 <script>
 	if (!mapboxgl.supported()) {
  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can edit files directly in your browser

  • 🏁 Done Ask in comments for a review :)

🤔 Questions

Leave a comment below!

This issue was created by First-Timers-Bot.

@jimthoburn jimthoburn changed the title Update location-list.html Update MapBox version for the “locations” page Apr 10, 2019

@alex-andres

This comment has been minimized.

Copy link

commented Apr 30, 2019

Hello Jim and the rest of the dev team!

I am eager to start making contributions to open source projects and would like to claim this issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.