Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How long did it took to be printed in file details #1048

Closed
javichumellamo opened this issue Sep 4, 2015 · 11 comments

Comments

Projects
None yet
6 participants
@javichumellamo
Copy link

commented Sep 4, 2015

In the Files list, you can see when a file was printed for the last time, it will be quite useful to show how long did it took.

@GitIssueBot

This comment has been minimized.

Copy link
Collaborator

commented Sep 4, 2015

Hi @javichumellamo,

It looks like there is some information missing from your ticket that will be needed in order to process it properly. Please take a look at the Contribution Guidelines and the page How to file a bug report on the project wiki, which will tell you exactly what your ticket has to contain in order to be processable.

If you did not intend to report a bug, please take special note of the title format to use as described in the Contribution Guidelines.

I'm marking this one now as needing some more information. Please understand that if you do not provide that information within the next two weeks (until 2015-09-18 23:40) I'll close this ticket so it doesn't clutter the bug tracker. This is nothing personal, so please just be considerate and help the maintainers solve this problem quickly by following the guidelines linked above. Thank you!

Best regards,
~ Your friendly GitIssueBot

PS: I'm just an automated script, not a human being, so don't expect any replies from me :) Your ticket is read by humans too, I'm just not one of them.

@foosel

This comment has been minimized.

Copy link
Owner

commented Sep 5, 2015

Should only be done for the last print time on the current printer profile.

@javichumellamo I've now manually marked this as a request but please read what the bot told you above, you could have done that yourself by just prefixing the title of you ticket and that way already helped us help you.

@ntoff

This comment has been minimized.

Copy link
Contributor

commented Sep 5, 2015

Am I missing something? It does show that stuff, in the history tab.

@markwal

This comment has been minimized.

Copy link
Collaborator

commented Sep 5, 2015

Yes, @javichumellamo, the duration of the last print shows when you open the info for an item with the down arrow button. Also, there is the PrintHistory plugin which you might find useful.

@javichumellamo

This comment has been minimized.

Copy link
Author

commented Sep 5, 2015

@markwal, when I open the info for an item, I can see the estimated print time, but what I'm wanting to get is the real time it took to be printed for the last time. I know I can use PrintHistory, but I think this simple change will improve the UI usability.

@ntoff

This comment has been minimized.

Copy link
Contributor

commented Sep 5, 2015

so, like this?
http://i.imgur.com/26GM8XU.jpg

changed https://github.com/foosel/OctoPrint/blob/master/src/octoprint/static/js/app/viewmodels/files.js#L334
from
output += gettext("Last Print Time") + ": " + formatDuration(data["prints"]["last"]["lastPrintTime"]);
to
output += gettext("Last Print Time") + ": " + formatDuration(data["prints"]["last"]["printTime"]);

and took away the if condition, not sure if that's the right way to do it, seemed to work but I only have one printer profile so can't test whether it works on multiple profiles. Also I'm using the dev version: Version: 1.2.6-dev-1-gae4e4f2-dirty (maintenance branch)

@javichumellamo

This comment has been minimized.

Copy link
Author

commented Sep 5, 2015

That's !!! it seems to work for me running 1.2.6 stable but I agree, we need additional testing

@ntoff

This comment has been minimized.

Copy link
Contributor

commented Sep 5, 2015

You can also leave the if condition in there if you change it too but I removed it because with it there, if there's no data then it just doesn't show up and for me, I would rather see it just give me a dash (-) if there's no data, than hide the information all together.

That's just personal preference though and leaving the if condition in there, makes it look more clean I suppose.

@hgeorge94

This comment has been minimized.

Copy link

commented Feb 22, 2016

It would appear that this issue might already be implemented, but it is still up-for-grabs. Does this issue need further work, or does it just need to be resolved?

@foosel

This comment has been minimized.

Copy link
Owner

commented Feb 22, 2016

Never got a PR for that, so it is still open.

I-am-me added a commit to I-am-me/OctoPrint that referenced this issue Sep 29, 2016

Changed "Last (estimated) print time" to real time
To answer foosel#1048 I changed L357 to "output += gettext("Last Print Time") + ": " + formatDuration(data["prints"]["last"]["printTime"]);" as proposed by @ntoff
@foosel

This comment has been minimized.

Copy link
Owner

commented Oct 4, 2016

Now I got a PR for that by @I-am-me which is now merged on the devel branch, hence this can be considered implemented. Will be part of the 1.3.0 release :)

@foosel foosel closed this Oct 4, 2016

DeviousFusion pushed a commit to UTA-FabLab/OctoPuppet that referenced this issue Sep 12, 2017

Changed "Last (estimated) print time" to real time
To answer foosel/OctoPrint#1048 I changed L357 to "output += gettext("Last Print Time") + ": " + formatDuration(data["prints"]["last"]["printTime"]);" as proposed by @ntoff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.