Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't delete mp4 timelapses and wrong filename displayed in notification of completion #1320

Closed
ntoff opened this issue Apr 29, 2016 · 1 comment

Comments

Projects
None yet
2 participants
@ntoff
Copy link
Contributor

commented Apr 29, 2016

With the addition of the ability to view and download mp4's through a wrapper script it seems you can't delete them. Additionally the wrong file extension is used when displaying the rendering complete notification.

guysoft/OctoPi#184 wrapper script


What were you doing?

Testing time lapse mp4 rendering

What did you expect to happen?

Render out to mp4 and be able to delete / download mp4

What happened instead?

mp4 rendered fine, downloads work, deleting doesn't remove any files. Additionally even though mp4 is rendered the mpeg extension is still used in the notification of rendering completion. I suggest perhaps simply removing the extension all together in the notification popup since detecting the type of file is probably impossible when using the wrapper script.

Branch & Commit or Version of OctoPrint

Version: 1.2.11.dev12+g119f727 (maintenance branch)

Printer model & used firmware incl. version

Mendel90 Sturdy running Marlin from ye olde times

Browser and Version of Browser, Operating System running Browser

Chrome Version 49.0.2623.112 m on windows 10 pro

Link to octoprint.log

https://gist.github.com/ntoff/09fb33daaf309c100116c20aaf96b32f

Link to contents of terminal tab or serial.log

nothing there aside from the usual temperature request / responses

Link to contents of Javascript console in the browser

Nothing obvious http://i.imgur.com/uoB65wf.png and it's pretty empty

Screenshot(s) showing the problem:

screenshot of incorrect file extension
http://i.imgur.com/A3X2Jy2.png

I have read the FAQ.

@CapnBry CapnBry referenced this issue May 31, 2016

Closed

Deletemp4 #1358

@foosel foosel added this to the 1.2.12 milestone Jun 2, 2016

foosel added a commit that referenced this issue Jun 2, 2016

Allow deletion of *.mp4 timelapse files
That one was missing in a00faf2.

Fixes #1320

@foosel foosel added the status:solved label Jun 2, 2016

foosel added a commit that referenced this issue Jun 2, 2016

Use movie prefix for timelapse notifications
Also added a missing lock.

Also part of the fix for #1320
@foosel

This comment has been minimized.

Copy link
Owner

commented Jun 2, 2016

Solved on both devel and maintenance branch, will be part of the next release.

@foosel foosel closed this Jun 2, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.