Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Daemonized OctoPrint does not clean up pidfile anymore #1324

Closed
kevans91 opened this issue May 4, 2016 · 2 comments

Comments

Projects
None yet
2 participants
@kevans91
Copy link
Contributor

commented May 4, 2016

What were you doing?

Writing an rc script for FreeBSD. Reproduction steps:

octoprint --daemon start --pid /tmp/octoprint.pid
kill -TERM `cat /tmp/octoprint.pid`
ls -l /tmp/octoprint.pid

/tmp/octoprint.pid persists -- this was previously addressed in issue #711 with PR #712, but it has since broken. The following SIGTERM registration clobbers this handler: https://github.com/foosel/OctoPrint/blob/master/src/octoprint/server/__init__.py#L511-L516 -- so the daemonize'd SIGTERM does not get called, and the pidfile does not get cleaned up.

What did you expect to happen?

pidfile to get cleaned up

What happened instead?

pidfile did not get cleaned up

Branch & Commit or Version of OctoPrint

Verified on:

master & maintenance: e79703b
devel: 1b1148d

Link to octoprint.log

https://gist.github.com/kevans91/b11ea167ec1fd9d4c4159400608abcd2

I have read the FAQ.

@foosel

This comment has been minimized.

Copy link
Owner

commented May 20, 2016

Fixed in both maintenance and devel, will be in next release, can be closed, right?

@kevans91

This comment has been minimized.

Copy link
Contributor Author

commented May 20, 2016

Yup! =)

@kevans91 kevans91 closed this May 20, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.