Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timleapse rendering message does not dissapear on render fail #1343

Closed
derpicknicker1 opened this issue May 18, 2016 · 1 comment

Comments

Projects
None yet
2 participants
@derpicknicker1
Copy link
Contributor

commented May 18, 2016

What were you doing?

I tried to use a relative snapshot URL. This let the timleapse modul throw many exception. Ok. Will not work. Not that bad for me. BUT after stopping the Print, i got the message that the video will be rendered (at the top right of browser). This message will not dissappear or change for hours (sure i can close).

What did you expect to happen?

I expected that the "rendering info" will tell me at some point that the rendering failed.
I also expected that octoprint let me know if the snapshot url will not work instead of silently throw exceptions.

What happened instead?

The "I'm rendering" anouncement stays open forever with no feedback.

Branch & Commit or Version of OctoPrint

1.2.11 (master)

Printer model & used firmware incl. version

Printer moddel : custom
FW: Marlin 1.0.2

Browser and Version of Browser, Operating System running Browser

Chrome on WIN10 (both up to date)

Link to octoprint.log

https://gist.github.com/derpicknicker1/ed2886a970506482e793bd6e4faf300c

Link to contents of terminal tab or serial.log

not relevant

Link to contents of Javascript console in the browser

got no message from javascript

Screenshot(s) showing the problem:

💻

I have read the FAQ.

@foosel foosel added this to the 1.2.12 milestone May 20, 2016

foosel added a commit that referenced this issue Jun 1, 2016

Do not sort events in the event queue alphabetically
This should never have been a PriorityQueue, or at the very least it should
never have the data itself in a sortable structure.

Thanks to processing speed of the event queue that seldomly showed,
only in cases where two events entered the queue almost simultanously,
e.g. when starting to render a timelapse movie and immediately failing.

Should solve #1343

@foosel foosel added the status:solved label Jun 1, 2016

@foosel

This comment has been minimized.

Copy link
Owner

commented Jun 1, 2016

Fixed in maintenance and devel branches, will be part of the next release.

@foosel foosel closed this Jun 1, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.