Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

M114 output (related to issues 1373) #1385

Closed
MoonshineSG opened this issue Jun 22, 2016 · 2 comments

Comments

Projects
None yet
2 participants
@MoonshineSG
Copy link

commented Jun 22, 2016

What were you doing?

Below mentioned commit causes issues with plugins which process lines output line from M114 to read the current XYZ values...

The output from M114 doesn't get add to "messages" in "current"

What did you expect to happen?

received M114 output

What happened instead?

received empty data because comm.py#L1050

if 'X:' in line and 'Y:' in line and 'Z:' in line:
    pass

Branch & Commit or Version of OctoPrint

ad201b0

Printer model & used firmware incl. version

marlin (custom)

Browser and Version of Browser, Operating System running Browser

n/a

Link to octoprint.log

not needed

Link to contents of terminal tab or serial.log

not needed

Link to contents of Javascript console in the browser

not needed

Screenshot(s) showing the problem:

not needed

I have read the FAQ.

@foosel foosel modified the milestone: 1.2.14 Jun 29, 2016

@foosel

This comment has been minimized.

Copy link
Owner

commented Jul 14, 2016

Fixed in maintenance and devel branches.

@foosel

This comment has been minimized.

Copy link
Owner

commented Jul 28, 2016

Merged to master and released with 1.2.14

@foosel foosel closed this Jul 28, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.