Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File upload headers do not support ISO-8859-1, 500 Internal Server Error gets triggered #1483

Closed
foosel opened this issue Sep 7, 2016 · 1 comment

Comments

Projects
None yet
1 participant
@foosel
Copy link
Owner

commented Sep 7, 2016

Problem

OctoPrint currently expects the filename field value on upload requests to be encoded as UTF-8. According to e.g. RFC 7230 the default for HTTP headers is ISO-8859-1 (or even ASCII) however, and clients encoding their filename field

Solution

Try ISO-8859-1 encoding additionally to UTF-8 for the multipart headers. If that fails do not return a 500 Internal Server Error but instead properly handle that case of malformed request and send a 400 Bad Request to the client.

Already implemented in 13728c2, ticket only created for documentation purposes.

@foosel foosel added this to the 1.2.16 milestone Sep 7, 2016

@foosel foosel self-assigned this Sep 7, 2016

@foosel

This comment has been minimized.

Copy link
Owner Author

commented Sep 24, 2016

Fixed in 1.2.16 which was released yesterday. Also fixed on devel.

@foosel foosel closed this Sep 24, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.