Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate/Delete API Key in user settings broken #1491

Closed
foosel opened this issue Sep 12, 2016 · 0 comments

Comments

Projects
None yet
1 participant
@foosel
Copy link
Owner

commented Sep 12, 2016

Problem

The generate and delete API key buttons in the user settings are not working. The request they trigger is generated for an API endpoint lacking the name of the current user. The reason for that is reusing the existing confirmGenerateApikey and confirmDeleteApikey methods on the injected UsersViewModel, which depend on currentUser being set on the UsersViewModel which the user settings dialog doesn't do.

Solution

Instead of reusing the confirm* methods on the UsersViewModel, use the actual request implementations generateApikey(username, callback) and deleteApikey(username, callback) and provide the user's name for the current settings dialog as parameter.

@foosel foosel added this to the 1.2.16 milestone Sep 12, 2016

@foosel foosel self-assigned this Sep 12, 2016

@foosel foosel closed this in 0167015 Sep 23, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.