Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug report] Login issues on 1.2.17rc1 with IE11 and Android Browser #1544

Closed
avoid200 opened this issue Oct 12, 2016 · 3 comments

Comments

Projects
None yet
4 participants
@avoid200
Copy link

commented Oct 12, 2016

What were you doing?

I have updated from version 1.2.16 to 1.2.17rc1.

What were you doing?

I have done an update via the web interface.
After that I try to log back into Octoprint.

What did you expect to happen?

The login should have worked.

What happened instead?

It works only with Firefox (49.0.1), not with IE (11.0.9600.18349) and also not on Android Smartphone / Tablet. Only Firefox reacts when the login button is pressed, the other browser does not.

Branch & Commit or version of OctoPrint

Before the update 1.2.16.
Now 1.2.17rc1.

Printer model & used firmware incl. Version

Printer: Vellemann Vertex K8400 (electronics replaced by Ramps 1.4).
Firmware: Marlin 1.1.0-RC7 - 31 July 2016

Browser and Version of Browser, Operating System running Browser

Windows 7 Pro 64Bit / Android
Firefox (49.0.1) / Internet Explorer (11.0.9600.18349) / Android standard browser

Link to octoprint.log

https://gist.github.com/anonymous/13012510ec5e4f9af25b531ed187e94d#file-octoprint-log

link to contents of terminal tab or serial.log

unavailable.

link to contents of javascript console in the browser

unavailable.

Screenshot (s) showing the problem:

unavailable.

@GitIssueBot

This comment has been minimized.

Copy link
Collaborator

commented Oct 12, 2016

Hi @avoid200,

It looks like there is some information missing from your bug report that will be needed in order to solve the problem. Read the Contribution Guidelines which will provide you with a template to fill out here so that your bug report is ready to be investigated (I promise I'll go away then too!).

If you did not intend to report a bug but wanted to request a feature or brain storm about some kind of development, please take special note of the title format to use as described in the Contribution Guidelines.

Please do not abuse the bug tracker as a support forum - if you have a question or otherwise need some kind of help or support refer to the Mailinglist or the G+ Community instead of here.

Also make sure you are at the right place - this is the bug tracker of the official version of OctoPrint, not the Raspberry Pi image OctoPi nor any unbundled third party OctoPrint plugins or unofficial versions. Make sure too that you have read through the Frequently Asked Questions and searched the existing tickets for your problem - try multiple search terms please.

I'm marking this one now as needing some more information. Please understand that if you do not provide that information within the next two weeks (until 2016-10-26 23:00 UTC) I'll close this ticket so it doesn't clutter the bug tracker. This is nothing personal, so please just be considerate and help the maintainers solve this problem quickly by following the guidelines linked above. Remember, the less time the devs have to spend running after information on tickets, the more time they have to actually solve problems and add awesome new features. Thank you!

Best regards,
~ Your friendly GitIssueBot

PS: I'm just an automated script, not a human being, so don't expect any replies from me :) Your ticket is read by humans too, I'm just not one of them.

@ntoff

This comment has been minimized.

Copy link
Contributor

commented Oct 13, 2016

Works fine here on Windows 10 Pro
Octoprint: Version: 1.2.17rc1 (rc/maintenance branch)
IE 11.494.10586.0
"Internet" on Android 6.0.1 (whatever browser that is) on a Samsung tablet.

Have you tried clearing your internet cache?

@foosel

This comment has been minimized.

Copy link
Owner

commented Oct 13, 2016

Just tested on IE myself: 11.633.10586.0. Login worked perfectly fine. Don't have an Android device on hand ancient enough that it still doesn't ship with Chrome as browser by default, so couldn't cross check there personally.

The only change between 1.2.16 and 1.2.17rc1 even remotely related to login behaviour was making sure to on logout also delete the old remember_me cookie, not only the new suffixed version remember_me_P<port>.

Which made me highly doubt an issue with OctoPrint here and rather something like a plugin interfering (by producing a js error that prevents the login from being properly processed). I noticed in your log (after splitting it back up into multiple lines :P) that you added the "Full-featured Slicer" plugin during updating to 1.2.17rc1 as well. So I just installed that and lo-and-behold, it contains Javascript code that can't be processed by IE11 and probably also not your Android tablet, the back ticks in this and this line to be precise (and possibly more places, that's only what I could find so far). I reported that in the plugin's bug tracker, please follow that ticket. Closing this one since it's not a bug with OctoPrint but a plugin that you installed.

BTW: The javascript console is a must to debug things like this, and it is available even in IE11 by hitting "F12" and then selecting "Console".

@foosel foosel closed this Oct 13, 2016

foosel added a commit that referenced this issue Oct 13, 2016

Split JS/CSS/LESS assets between core+bundled plugins and external pl…
…ugins

That way a JS error in an external plugin won't nuke the whole UI, which IMHO
is worth the additional requests needed to load the split up files.

See #1544 for an example of such a situation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.