Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] Migrate manually configured restart/reboot commands to new core system commands #1593

Closed
theunruly opened this issue Nov 18, 2016 · 6 comments

Comments

Projects
None yet
3 participants
@theunruly
Copy link

commented Nov 18, 2016

Latest dev Octoprint showing duped menu for system. Uninstalled TouchUI Plugin as test, items still duped.

What were you doing?

Header Menu in UI > System Menu > Items are duplicated
Restart OctoPrint
Reboot
Shutdown

Shutdown
Reboot
Restart Octoprint

What did you expect to happen?

Items to not be duplicated

What happened instead?

Duplicated Items

Branch & Commit or Version of OctoPrint

Version 1.3.0rc1 (rc/devel branch)

Printer model & used firmware incl. version

Tevo Tarantula - Marlin 1.1 rc7
MP Select Mini - Maylan 22.39

Browser and Version of Browser, Operating System running Browser

Chrome Version 54.0.2840.99 m Windows 10
Reproducible on 4 separate computers 2 networks.

Link to octoprint.log

http://pastebin.com/Viy0KZUE

Link to contents of terminal tab or serial.log

Link to contents of Javascript console in the browser

Screenshot(s) showing the problem:

octoprint_ui_dupe

I have read the FAQ.

@AlexanderPro29

This comment has been minimized.

Copy link

commented Nov 18, 2016

I also want to note that these items are not translated when changing languages.

@foosel

This comment has been minimized.

Copy link
Owner

commented Nov 18, 2016

To quote the release announcement on the OctoBlog:

If you already had the system commands configured manually or had gotten them preconfigured through OctoPi, they’ll now show up twice - this can be rectified by simply removing the manually configured system commands, but you might want to wait with that until the stable release of 1.3.0 :) I might also still add some migration step for that.

So that is a known issue.

The entries (from core, not from config.yaml) should adjust depending on selected language however, and that appears to be broken.

foosel added a commit that referenced this issue Nov 18, 2016

Allow locale definition via request header
Important for session less API calls that might return
localized content (e.g. the system commands).

See #1593

foosel added a commit that referenced this issue Nov 18, 2016

If l10n is set on page load, set OctoPrint.options.locale to its value
That way API requests will be made with the locale the page was requested
in.

See #1593
@foosel

This comment has been minimized.

Copy link
Owner

commented Nov 18, 2016

Translation issue has been fixed on devel via the above three commits.

Rephrasing ticket to make it a request for (attempting) system command migration on start, at least for the redundant versions rolled out with OctoPi/suggested in the official setup guide. No way to migrate arbitrary (renamed & changed) system commands for restarting/rebooting.

@foosel foosel changed the title UI > System Menu | Items in Menu Duplicated [Request] Migrate manually configured restart/reboot commands to new core system commands Nov 18, 2016

@foosel foosel added the type:request label Nov 18, 2016

@foosel foosel added this to the 1.3.0 milestone Nov 18, 2016

@foosel

This comment has been minimized.

Copy link
Owner

commented Nov 18, 2016

That's now implemented on devel and will be in 1.3.0rc2. See commits fc06c91 and 71581c9

@theunruly

This comment has been minimized.

Copy link
Author

commented Nov 18, 2016

I missed that blog entry, apologize for the duplicate post (see what I did there? lol) ... thanks!

@foosel

This comment has been minimized.

Copy link
Owner

commented Nov 25, 2016

1.3.0rc2 is out

@foosel foosel closed this Nov 25, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.