Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to delete folder with a name that's a prefix of the current file being printed #1637

Closed
herrerodani opened this issue Dec 9, 2016 · 7 comments

Comments

Projects
None yet
3 participants
@herrerodani
Copy link

commented Dec 9, 2016

I recently upgraded to Octoprint 1.3.0 and created a folder named "Imperial Assault". Octoprint renamed it to "Imperial_Assault" and I'm unable to delete it. In octoprint.log it reads:
2016-12-09 12:05:03,101 - tornado.access - WARNING - 409 DELETE /api/files/local/Imperial_Assault (127.0.0.1) 28.17ms

@foosel

This comment has been minimized.

Copy link
Owner

commented Dec 9, 2016

I said full ticket template ;) But ok. 409 hints at it not being able to delete it because you are currently printing a file from it or similar. Might that be the case?

@GitIssueBot

This comment has been minimized.

Copy link
Collaborator

commented Dec 9, 2016

Hi @herrerodani,

It looks like there is some information missing from your bug report that will be needed in order to solve the problem. Read the Contribution Guidelines which will provide you with a template to fill out here so that your bug report is ready to be investigated (I promise I'll go away then too!).

If you did not intend to report a bug but wanted to request a feature or brain storm about some kind of development, please take special note of the title format to use as described in the Contribution Guidelines.

Please do not abuse the bug tracker as a support forum - if you have a question or otherwise need some kind of help or support refer to the Mailinglist or the G+ Community instead of here.

Also make sure you are at the right place - this is the bug tracker of the official version of OctoPrint, not the Raspberry Pi image OctoPi nor any unbundled third party OctoPrint plugins or unofficial versions. Make sure too that you have read through the Frequently Asked Questions and searched the existing tickets for your problem - try multiple search terms please.

I'm marking this one now as needing some more information. Please understand that if you do not provide that information within the next two weeks (until 2016-12-23 11:50 UTC) I'll close this ticket so it doesn't clutter the bug tracker. This is nothing personal, so please just be considerate and help the maintainers solve this problem quickly by following the guidelines linked above. Remember, the less time the devs have to spend running after information on tickets, the more time they have to actually solve problems and add awesome new features. Thank you!

Best regards,
~ Your friendly GitIssueBot

PS: I'm just an automated script, not a human being, so don't expect any replies from me :) Your ticket is read by humans too, I'm just not one of them.

@herrerodani

This comment has been minimized.

Copy link
Author

commented Dec 9, 2016

Thank you for your response. I'm not printing from the folder, but I'm printing a file named "Imperial_Assault_Door_Closedx4.gcode" which is in the root.

What were you doing?

I upgraded to 1.3.0 master branch and tried the new folder functionality creating a folder named "Imperial Assault" then tried to delete it. I'm also printing a file in root named "Imperial_Assault_Door_Closedx4.gcode"

What did you expect to happen?

The folder to be deleted

What happened instead?

Otoprint renamed the folder to "Imperial_Assault" and I'm unable to delete it.

Branch & Commit or Version of OctoPrint

1.3.0 master branch

Printer model & used firmware incl. version

Prusa i3 Hephestos 1.4.2 BQ Hephestos

Browser and Version of Browser, Operating System running Browser

latest Chrome, Ubuntu 14

Link to octoprint.log

2016-12-09 12:05:03,101 - tornado.access - WARNING - 409 DELETE /api/files/local/Imperial_Assault (127.0.0.1) 28.17ms

Link to contents of terminal tab or serial.log

Link to contents of Javascript console in the browser

Screenshot(s) showing the problem:

I have read the FAQ.

@foosel

This comment has been minimized.

Copy link
Owner

commented Dec 9, 2016

Ah. That is a bug then :D Unrelated to the spaces in the filename though. It thinks because the file that is currently being printed starts with the folder name it is in the folder. Looks like the "is busy" check is a bit too broad there :)

@foosel

This comment has been minimized.

Copy link
Owner

commented Dec 9, 2016

And fixed by above commit on maintenance, will be released with 1.3.1(rc1). Marking as solved and keeping this open until this is the case

@foosel foosel added the status:solved label Dec 9, 2016

@foosel foosel changed the title Unable to delete folder Unable to delete folder with a name that's a prefix of the current file being printed Dec 9, 2016

@herrerodani

This comment has been minimized.

Copy link
Author

commented Dec 9, 2016

Yeah, that was it. Once the Printer ended printing "Imperial_Assault_Door_Closedx4.gcode" I could delete "Imperial_Assault" folder. Thank you very much for your work.

@foosel

This comment has been minimized.

Copy link
Owner

commented Jan 25, 2017

Part of 1.3.1 which has just been released.

@foosel foosel closed this Jan 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.