Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add websocket-client as a dependancy #1648

Closed
timothyhollabaugh opened this issue Dec 12, 2016 · 4 comments

Comments

Projects
None yet
2 participants
@timothyhollabaugh
Copy link

commented Dec 12, 2016

What were you doing?

Trying to use the octoprint client listen command to get updates from Octoprint.

What did you expect to happen?

I expected the octoprint client listen to show messages from the Octoprint server

What happened instead?

It gave me an error message about no module named websocket

➜  octoprint git:(master) octoprint client listen               
Traceback (most recent call last):
  File "/usr/bin/octoprint", line 9, in <module>
    load_entry_point('OctoPrint', 'console_scripts', 'octoprint')()
  File "/usr/lib/python2.7/site-packages/OctoPrint-1.3.0.dev1245+gcba742a-py2.7.egg/octoprint/__init__.py", line 310, in main
    octo(args=args, prog_name="octoprint", auto_envvar_prefix="OCTOPRINT")
  File "/usr/lib/python2.7/site-packages/click-6.2-py2.7.egg/click/core.py", line 716, in __call__
    return self.main(*args, **kwargs)
  File "/usr/lib/python2.7/site-packages/click-6.2-py2.7.egg/click/core.py", line 696, in main
    rv = self.invoke(ctx)
  File "/usr/lib/python2.7/site-packages/click-6.2-py2.7.egg/click/core.py", line 1060, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/usr/lib/python2.7/site-packages/click-6.2-py2.7.egg/click/core.py", line 1060, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/usr/lib/python2.7/site-packages/click-6.2-py2.7.egg/click/core.py", line 889, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/usr/lib/python2.7/site-packages/click-6.2-py2.7.egg/click/core.py", line 534, in invoke
    return callback(*args, **kwargs)
  File "/usr/lib/python2.7/site-packages/OctoPrint-1.3.0.dev1245+gcba742a-py2.7.egg/octoprint/cli/client.py", line 176, in listen
    on_message=on_message)
  File "/usr/lib/python2.7/site-packages/OctoPrint-1.3.0.dev1245+gcba742a-py2.7.egg/octoprint_client/__init__.py", line 382, in connect_socket
    socket.connect()
  File "/usr/lib/python2.7/site-packages/OctoPrint-1.3.0.dev1245+gcba742a-py2.7.egg/octoprint_client/__init__.py", line 124, in connect
    self._prepare()
  File "/usr/lib/python2.7/site-packages/OctoPrint-1.3.0.dev1245+gcba742a-py2.7.egg/octoprint_client/__init__.py", line 59, in _prepare
    import websocket
ImportError: No module named websocket

I found that after installing the websocket-client module, it works as expected.
I also found no reference to it in setup.py

Branch & Commit or Version of OctoPrint

Version 1.3.0 from the master branch

Printer model & used firmware incl. version

Marlin
Not applicable

Browser and Version of Browser, Operating System running Browser

Not applicable

Link to octoprint.log

https://gist.github.com/chickenchuck040/cba0f5c30e0d95481d8111a4d145d1c9

Link to contents of terminal tab or serial.log

Not applicable

Link to contents of Javascript console in the browser

Not applicable

Screenshot(s) showing the problem:

Not Applicable

I have read the FAQ.

@foosel

This comment has been minimized.

Copy link
Owner

commented Dec 13, 2016

Ouch. Sorry for that and thanks for the heads-up

@foosel foosel added this to the 1.3.1 milestone Dec 13, 2016

foosel added a commit that referenced this issue Dec 13, 2016

@foosel

This comment has been minimized.

Copy link
Owner

commented Dec 13, 2016

Solved in above commit. Will be in 1.3.1

@timothyhollabaugh

This comment has been minimized.

Copy link
Author

commented Dec 13, 2016

Thanks for the quick response!

@foosel

This comment has been minimized.

Copy link
Owner

commented Jan 25, 2017

Part of 1.3.1 which has just been released.

@foosel foosel closed this Jan 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.