Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

profile.py does not parse perimeter_before_infill #1693

Closed
torch-senouen opened this issue Jan 7, 2017 · 3 comments

Comments

Projects
None yet
2 participants
@torch-senouen
Copy link

commented Jan 7, 2017

What were you doing?

While trouble shooting print quality issues I wanted to experiment with printing the perimeter before infill (Cura option variable perimeterBeforeInfill). I went to check this option in my slicing profile and noticed the option was missing completely from my profile. [EDIT]( I added the option "perimeter_before_infill" to my slicing profile which had no effect on changing the option "perimeterBeforeInfill".) Upon further investigation I noticed that OctoPrint/src/octoprint/plugins/cura/profile.py does not have a rule to parse "perimeterBeforeInfill" from "perimeter_before_infill" in the function convert_to_engine, or anywhere else in the program.

I found Issue #1141 that was closed because the ticket was incomplete.

As a temporary fix I have modified my own profile.py with a line in convert_to_engine to set "perimeterBeforeInfill": 1 which has fixed the problem.

What did you expect to happen?

I expected when setting the variable perimeter_before_infill: true in my Cura slicing profile that the CuraEngine option perimeterBeforeInfill would be set to 1.

What happened instead?

The option is not parsed and the default value 0 is used.

Branch & Commit or Version of OctoPrint

Version: 1.3.0.post0.dev0+g7f5d03d (master branch)

Printer model & used firmware incl. version

N/A

Browser and Version of Browser, Operating System running Browser

N/A

Link to octoprint.log

http://pastebin.com/SkbqR6F2

Link to contents of terminal tab or serial.log

http://pastebin.com/jTwzND1v

Link to Cura slicing profile

http://pastebin.com/Ank8vXUg

Screenshot(s) showing the problem:

N/A

I have read the FAQ.

@foosel

This comment has been minimized.

Copy link
Owner

commented Jan 9, 2017

@foosel

This comment has been minimized.

Copy link
Owner

commented Jan 11, 2017

Fixed on maintenance (and soon also devel), will be released with 1.3.1

@foosel foosel added this to the 1.3.1 milestone Jan 11, 2017

@torch-senouen

This comment has been minimized.

Copy link
Author

commented Jan 11, 2017

Great, thanks @foosel !

@foosel foosel closed this in 7c74594 Jan 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.