Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] Suppress update notifications when logged in as non-admin user #1739

Closed
pelrun opened this issue Jan 29, 2017 · 1 comment

Comments

Projects
None yet
3 participants
@pelrun
Copy link

commented Jan 29, 2017

Anyone logged into a non-admin account still sees all the update notifications even though they're completely unable to actually perform the update. So it's unnecessary to actually show them those notifications. They also can't tell octoprint to ignore the update, so they're forced to see the notification every time they log in until the admin user comes along and deals with it.

I'm using octoprint to manage multiple printers in my hackerspace, so everyone else except for myself gets the non-admin guest account, because we don't really need full access control but want to restrict configuration to the person maintaining them. But everyone gets spammed with update notifications, even though I'm the only one who can actually deal with them.

@foosel foosel added this to the 1.3.3 milestone Mar 28, 2017

@foosel

This comment has been minimized.

Copy link
Owner

commented Mar 29, 2017

I added an option to the Software Update Plugin Settings to allow disabling notifications for users that are not admins (checked by default, to keep current behaviour for people who rely on it):

image

I also added the "Ignore" button to the notification and a hint to seek an admin for updating:

image

The notification will also now auto-hide on log-out, and the browser will remember the ignore state on a per-user base (that way a user ignoring the notification, then logging out and handing over control to an admin will still have the notification show up for the admin).

Pushed to maintenance, soon devel, will be released with 1.3.3.

@foosel foosel closed this in fda67f4 May 31, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.