Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timelapse settings "save config" button feedback. [request] #1811

Closed
rewolff opened this issue Mar 8, 2017 · 8 comments

Comments

Projects
None yet
4 participants
@rewolff
Copy link

commented Mar 8, 2017

Hi,
Possibly already fixed, but.. I'm running 1.3.0-something-git. (on my "production" 3D printer.. It works, don't touch it....).

I started a print, but before the bed was up to temperature I decided that I wanted to change the timelapse parameters for this print. So I hit cancel (no harm done), and tried configuring the timelapse... Then it tells me I need to wait 20 minutes before that becomes possible.... Sigh. This should be abort-able just like a 3D print.

In any case the "save config" button never gave any feedback that anything happened.

@GitIssueBot

This comment has been minimized.

Copy link
Collaborator

commented Mar 8, 2017

Hi @rewolff,

It looks like there is some information missing from your bug report that will be needed in order to solve the problem. Read the Contribution Guidelines which will provide you with a template to fill out here so that your bug report is ready to be investigated (I promise I'll go away then too!).

If you did not intend to report a bug but wanted to request a feature or brain storm about some kind of development, please take special note of the title format to use as described in the Contribution Guidelines.

Please do not abuse the bug tracker as a support forum - if you have a question or otherwise need some kind of help or support refer to the Mailinglist or the G+ Community instead of here.

Also make sure you are at the right place - this is the bug tracker of the official version of OctoPrint, not the Raspberry Pi image OctoPi nor any unbundled third party OctoPrint plugins or unofficial versions. Make sure too that you have read through the Frequently Asked Questions and searched the existing tickets for your problem - try multiple search terms please.

I'm marking this one now as needing some more information. Please understand that if you do not provide that information within the next two weeks (until 2017-03-22 07:50 UTC) I'll close this ticket so it doesn't clutter the bug tracker. This is nothing personal, so please just be considerate and help the maintainers solve this problem quickly by following the guidelines linked above. Remember, the less time the devs have to spend running after information on tickets, the more time they have to actually solve problems and add awesome new features. Thank you!

Best regards,
~ Your friendly GitIssueBot

PS: I'm just an automated script, not a human being, so don't expect any replies from me :) Your ticket is read by humans too, I'm just not one of them.

@ntoff

This comment has been minimized.

Copy link
Contributor

commented Mar 10, 2017

is this a bug report or a feature request? There's never been any feedback for the save config button, apart from the fact that once saved it removes the check box from "save default" and greys itself out.

@rewolff

This comment has been minimized.

Copy link
Author

commented Mar 11, 2017

Maybe my eyes are bad that I'm having trouble seeing the difference between grayed out and not. Maybe it WAS grayed out, maybe not. But I tried pressing the "save" button and nothing happened. Took me a while to figure out.

@ntoff

This comment has been minimized.

Copy link
Contributor

commented Mar 15, 2017

You're right, in the default white theme (I've been staring at a dark theme for the past week, that I've been working on) there isn't much of a difference between it being enabled and not, though there is a difference.

I stuck some text on the page that pops up and notifies you that there's unsaved changes ntoff@381a016

@foosel You mentioned a spinner (which I didn't do), I've been spoiled by my i7's speed which saves insatntly. Would a spinner icon stay on the screen long enough to be noticed? Even if octoprint is running on a raspberry pi, I don't imagine the save process would take that long would it?. Perhaps that might come and go so quickly that it would be missed?

edit: p.s. @rewolff you might want to edit the title and add [request] at the beginning so the git bot doesn't automatically close this, thinking it's an incomplete bug report.

@rewolff rewolff changed the title Timelapse settings "save config" button feedback. Timelapse settings "save config" button feedback. [request] Mar 15, 2017

@rewolff

This comment has been minimized.

Copy link
Author

commented Mar 15, 2017

How about changing the text of the "save" button to say what it does and does not do.

SAVE, use for the next print
SAVE, use for all prints in the future
SAVE OK, these settings will be used for the next print
SAVE OK, these settings will be used for all prints in the future.

@foosel

This comment has been minimized.

Copy link
Owner

commented Mar 16, 2017

@ntoff I've merged your commit to maintenance. I've reworded things slightly so that the help text for the "Save as default" checkbox can always stay visible, and moved the "You have unsaved changes" to the right of the button to make it more visible:

image

I also worked a bit on properly reporting back the current default settings, but that didn't work out so far (some error in my logic). I'll have to take another look at that.

@foosel

This comment has been minimized.

Copy link
Owner

commented May 11, 2017

To be released with 1.3.3 as depicted above.

@foosel foosel added this to the 1.3.3 milestone May 11, 2017

@foosel

This comment has been minimized.

Copy link
Owner

commented May 31, 2017

1.3.3 was just released.

@foosel foosel closed this May 31, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.