Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Test" button to webcam config [WAS: error check snapshot for timelapse] #183

Closed
fehknt opened this issue Jul 7, 2013 · 3 comments

Comments

Projects
None yet
2 participants
@fehknt
Copy link

commented Jul 7, 2013

Was puzzling over my broken timelapse for a while, had all these broken 3k jpeg files created with no errors until transcoding. Turns out that it just downloaded the default mjpeg-streamer webpage that shows up for any action that is not prefixed with a valid action.

I'm thinking that something along these lines for console debugging might be nice?
http://stackoverflow.com/questions/266648/python-check-if-uploaded-file-is-jpg
(With or without the preview image)

Thoughts? Happy to implement / pull request, I like Python.

@foosel

This comment has been minimized.

Copy link
Owner

commented Jul 7, 2013

That would be implementing an otherwise unnecessary feature just for making sure that the user does not make a configuration mistake and add processing overhead (expensive file i/o) while doing so. Since the goal is to keep OctoPrint compatible with something as low-powered as a Raspberry Pi that would definitely be a step in the wrong direction.

However, I'd be ok with something along the lines of such a check during configuration (something like a "Test" button displayed next to the input for the snapshot URL in the settings page, which would try to capture the image and look whether it's a) possible and b) a valid image)

@fehknt

This comment has been minimized.

Copy link
Author

commented Jul 7, 2013

Philosophically, I agree on keeping it low-overhead, but I was figuring the last-written file would be in the OS cache anyway and checking the first few bytes would be cheap. That said, a "Test" button would work fine too, and then it doesn't matter how expensive the checks are because (within reason). I'll let you know if I end up writing it. Clearly everyone else manages to figure it out faster than me :)

@foosel

This comment has been minimized.

Copy link
Owner

commented Oct 2, 2015

image

image

image

Totally forgot to close this ticket - test buttons for both the snapshot and the stream are now implemented in devel. Client side. Will be included with the 1.3.x release (I will probably not backport it to 1.2.x since it needs a bunch of new stuff to work).

@foosel foosel closed this Oct 2, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.