Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra (and possibly unneeded most of the time) content loaded when initially loading Octoprint's UI in a browser #1858

Closed
pyjamasam opened this issue Apr 9, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@pyjamasam
Copy link

commented Apr 9, 2017

What were you doing?

Loading the octoprint homepage

What did you expect to happen and what happened instead?

I expected the resources needed to load octoprint and make it functional to be loaded.

What I see is that additional resources are loaded. Specifically resources that are part of the announcements (mostly images from the plugins channel).
And one of those images is 2.4MB.

This happens every fresh load of the octoprint interface.

Branch & Commit or Version of OctoPrint

OctoPrint 1.3.2 (master branch)

Operating System running OctoPrint

Raspberry PI 2B

Linux octoprint 3.18.11-v7+ #781 SMP PREEMPT Tue Apr 21 18:07:59 BST 2015 armv7l GNU/Linux

PRETTY_NAME="Raspbian GNU/Linux 7 (wheezy)"
NAME="Raspbian GNU/Linux"
VERSION="7 (wheezy)"

Printer model & used firmware incl. version

Micromake D1, Azteeg X5 Mini 1, latest edge of smoothieware

Browser and Version of Browser, Operating System running Browser

macOS Chrome 57.0.2987.133 (64-bit)

Link to octoprint.log

I don't think I need to include this as its a UI bug

Link to contents of terminal tab or serial.log

Same as above. Not needed for a UI bug

Link to contents of Javascript console in the browser

https://gist.github.com/pyjamasam/54dc29360adabfc4cd0f466317f2ebed

Screenshot(s) or video(s) showing the problem:

http://www.chrisandtennille.com/pictures/Screen%20Shot%202017-04-08%20at%2019.53.18.png

I have read the FAQ.

My guess is when channel data is loaded and the html is put into the corresponding dom objects the browser is loading the images (as it should since the dom has been updated).

But the announcements are hidden unless I go look at them. I don't think it should be loading all the related media every time.

@foosel

This comment has been minimized.

Copy link
Owner

commented Apr 10, 2017

Good point 👍 With the above commit images from the announcements are now lazy loading. Already on maintenance, soon on devel and to be released with 1.3.3.

@foosel foosel added this to the 1.3.3 milestone Apr 10, 2017

@foosel foosel closed this in 7c8f148 May 31, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.