Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

user management broken #1891

Closed
trivalik opened this issue Apr 29, 2017 · 4 comments

Comments

Projects
None yet
4 participants
@trivalik
Copy link

commented Apr 29, 2017

What were you doing?

I installed a fresh image of OctoPi and update then to latest version of OctoPrint. Now I am not able to create new user nor to change its password it the settings. The confirm button does nothing. I tried browser Chrome and Edge. So I added manual the user "stanley" without givem them a Password. I retried it on GUI again, but Password Change was also not working. So maybe show the log something about the Manual added user. I found out that it only happen in "Access Control". Means, if I try to change the Password in "User Settings" menu, it seems it works, because the window Closes, but in real is the Password not changed. I found also out if the password contains umlaut, i.e. äüö it does not work, if I use other ones, it changes the password.

What did you expect to happen?

Window of password change is closing or any other confirm message appear.

What happened instead?

The confirm button (maybe named other) just get the focus and noting more.

Branch & Commit or Version of OctoPrint

1.3.2

Printer model & used firmware incl. version

Marlin, last RCBugFix + changes for Anet printer

Browser and Version of Browser, Operating System running Browser

tried with Google Chrome 57 and Edge from Windows 10

Link to octoprint.log

I did not find in FAQ where it is: but good that I have to much time: /home/pi/.octoprint/logs/octoprint.log

2017-04-29 18:58:51,981 - octoprint.server - INFO - Preemptively caching / (ui _default) for {'query_string': 'l10n=de', 'path': '/', 'base_url': 'http://octopi.local/'}
2017-04-29 19:04:01,100 - octoprint.server.util.sockjs - INFO - New connection from client: 192.168.178.20
2017-04-29 19:04:02,952 - octoprint.plugins.announcements - INFO - Loaded channel _important from http://octoprint.org/feeds/important.xml in 0.3s
2017-04-29 19:06:48,308 - octoprint - ERROR - Exception on /api/users/stanley/password [PUT]
Traceback (most recent call last):
File "/home/pi/oprint/local/lib/python2.7/site-packages/Flask-0.10.1-py2.7.egg/flask/app.py", line 1817, in wsgi_app
response = self.full_dispatch_request()
File "/home/pi/oprint/local/lib/python2.7/site-packages/Flask-0.10.1-py2.7.egg/flask/app.py", line 1477, in full_dispatch_request
rv = self.handle_user_exception(e)
File "/home/pi/oprint/local/lib/python2.7/site-packages/Flask-0.10.1-py2.7.egg/flask/app.py", line 1381, in handle_user_exception
reraise(exc_type, exc_value, tb)
File "/home/pi/oprint/local/lib/python2.7/site-packages/Flask-0.10.1-py2.7.egg/flask/app.py", line 1475, in full_dispatch_request
rv = self.dispatch_request()
File "/home/pi/oprint/local/lib/python2.7/site-packages/Flask-0.10.1-py2.7.egg/flask/app.py", line 1461, in dispatch_request
return self.view_functionsrule.endpoint
File "/home/pi/oprint/local/lib/python2.7/site-packages/OctoPrint-1.3.2-py2.7.egg/octoprint/server/util/flask.py", line 1106, in decorated_view
return flask.ext.login.login_required(func)(*args, **kwargs)
File "/home/pi/oprint/local/lib/python2.7/site-packages/Flask_Login-0.2.2-py2.7.egg/flask_login.py", line 637, in decorated_view
return func(*args, **kwargs)
File "/home/pi/oprint/local/lib/python2.7/site-packages/OctoPrint-1.3.2-py2.7.egg/octoprint/server/api/users.py", line 149, in changePasswordForUser
userManager.changeUserPassword(username, data["password"])
File "/home/pi/oprint/local/lib/python2.7/site-packages/OctoPrint-1.3.2-py2.7.egg/octoprint/users.py", line 305, in changeUserPassword
passwordHash = UserManager.createPasswordHash(password)
File "/home/pi/oprint/local/lib/python2.7/site-packages/OctoPrint-1.3.2-py2.7.egg/octoprint/users.py", line 117, in createPasswordHash
return hashlib.sha512(password + salt).hexdigest()
UnicodeEncodeError: 'ascii' codec can't encode characters in position 1-2: ordinal not in range(128)
2017-04-29 19:06:48,325 - tornado.access - ERROR - 500 PUT /api/users/stanley/password (127.0.0.1) 48.00ms

Link to contents of terminal tab or serial.log

not at print time happen

Link to contents of Javascript console in the browser

?

Screenshot(s) showing the problem:

Not needed it should be clear.

I have read the FAQ.

@GitIssueBot

This comment has been minimized.

Copy link
Collaborator

commented Apr 29, 2017

Hi @trivalik,

It looks like there is some information missing from your bug report that will be needed in order to solve the problem. Read the Contribution Guidelines which will provide you with a template to fill out here so that your bug report is ready to be investigated (I promise I'll go away then too!).

If you did not intend to report a bug but wanted to request a feature or brain storm about some kind of development, please take special note of the title format to use as described in the Contribution Guidelines.

Please do not abuse the bug tracker as a support forum - if you have a question or otherwise need some kind of help or support refer to the Mailinglist or the G+ Community instead of here.

Also make sure you are at the right place - this is the bug tracker of the official version of OctoPrint, not the Raspberry Pi image OctoPi nor any unbundled third party OctoPrint plugins or unofficial versions. Make sure too that you have read through the Frequently Asked Questions and searched the existing tickets for your problem - try multiple search terms please.

I'm marking this one now as needing some more information. Please understand that if you do not provide that information within the next two weeks (until 2017-05-13 12:10 UTC) I'll close this ticket so it doesn't clutter the bug tracker. This is nothing personal, so please just be considerate and help the maintainers solve this problem quickly by following the guidelines linked above. Remember, the less time the devs have to spend running after information on tickets, the more time they have to actually solve problems and add awesome new features. Thank you!

Best regards,
~ Your friendly GitIssueBot

PS: I'm just an automated script, not a human being, so don't expect any replies from me :) Your ticket is read by humans too, I'm just not one of them.

@ntoff

This comment has been minimized.

Copy link
Contributor

commented Apr 30, 2017

I did not find in FAQ where it is: but good that I have to much time: /home/pi/.octoprint/logs/octoprint.log

Just for future reference there are links to all the logs in the settings menu (spanner icon)

foosel added a commit that referenced this issue May 2, 2017

@foosel

This comment has been minimized.

Copy link
Owner

commented May 2, 2017

Thanks for reporting, this should now be fixed on the maintenance branch, soon devel and will go into the 1.3.3 release.


I did not find in FAQ where it is: but good that I have to much time: /home/pi/.octoprint/logs/octoprint.log

Also for future reference: How to find everything that's requested from you in the ticket template is all explained in the contribution guidelines as linked on top of the new issue form, repeatedly hinted at in the pre filled contents of the new issue form, very roughly summarized in the issue template itself and also linked to by the bot :)

@foosel foosel added this to the 1.3.3 milestone May 2, 2017

@foosel

This comment has been minimized.

Copy link
Owner

commented May 31, 2017

1.3.3 was just released.

@foosel foosel closed this May 31, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.