Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Cura profile upload works even when no file is selected #1893
What were you doing?
What did you expect to happen and what happened instead?
I expected the Confirm button not to work when there is no profile selected.
Branch & Commit or Version of OctoPrint
I have read the FAQ.
I'm working on the solution to this in https://github.com/OctoPrint/OctoPrint-Slic3r . I'll solve it there and then port a similar fix for the cura plugin and send a PR.
referenced this issue
May 1, 2017
I merged your PR manually via a cherry-pick, see the above commit. Additionally I did some further refactoring because I noticed that the metadata of an uploaded profile didn't update properly after selecting the file to upload. I also made it so the "Confirm" button is actually disabled until you select a file to upload, and swapped out your manual click binding on the file select element with a knockout data bind (which now is possible thanks to your earlier refactoring).
All in all I think that should be pretty solid now. I briefly looked into completely going away from using the
Anyhow, this is already on