Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.3.3rc1 regression: Job data resets on completion #1917

Closed
foosel opened this issue May 15, 2017 · 0 comments

Comments

Projects
None yet
1 participant
@foosel
Copy link
Owner

commented May 15, 2017

Originally reported by @ctgreybeard in #1914 (see this comment).

Expected

Upon completion of a print job the information about needed print time, print time left, printed bytes & progress in the "State" panel should persist:

image

Actual

Instead it gets reset and while the information gets persisted to the metadata, its not as readily available as in 1.3.2:

image

Solution

Regression was introduced by 01ad9b8. on_comm_print_done handler resets the job data instead of setting it to 100% completion state. Fixing commit incoming...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.