Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.3.3rc1: "Save as default" on timelapse config not disabled alongside everything else when non operational #1918

Closed
foosel opened this issue May 15, 2017 · 3 comments

Comments

Projects
None yet
3 participants
@foosel
Copy link
Owner

commented May 15, 2017

Originally reported by @ntoff in #1914 (see this comment).

Expected

"Save as default" is disabled when all other settings are disabled as well due to the printer being offline.

Actual

It is not disabled and can be toggled. Doesn't do anything though.

image

Solution

Fix knockout data bindings.

Sidenote

It would probably make sense to allow timelapse configuration when the printer is not operational...

@foosel foosel self-assigned this May 15, 2017

@foosel foosel added this to the 1.3.3 milestone May 16, 2017

foosel added a commit that referenced this issue May 17, 2017

Allow timelapse config through UI when not connected to printer
That restriction didn't really make sense.

As mentioned in #1918

@foosel foosel closed this in 6d73e65 May 31, 2017

@jkyoutsey

This comment has been minimized.

Copy link

commented Mar 18, 2019

I can configure timelapse, but I cannot check the "Save as Default" button. I'm on 1.3.10

@foosel

This comment has been minimized.

Copy link
Owner Author

commented Mar 18, 2019

@jkyoutsey can you please open a full new ticket for that? This one is nearly two years old and there have since been so many changes to OctoPrint that it's probably unrelated.

@Gunnl

This comment has been minimized.

Copy link

commented May 10, 2019

@jkyoutsey , have you opened a new ticket? I am having same issue ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.