Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Issue with persistent options in gcode viewer in 1.3.6 RC1 #2267
What were you doing?
Running a print and testing the new features in the 1.3.6 RC1 changelog. Testing the features that I could test, including the persistent options in the gcode viewer. Discovered that when I toggled on "Also show next layer" and reloaded, I saw the gcode size warning (with a null size value) underneath the gcode viewer
To reproduce in my environment:
The same doesn't happen when choosing "Also show previous layer" - that works as expected and persists across page reloads. This is only a problem with "Also show next layer".
TL;DR: Check "Also show next layer" and reload - gcode viewer acts screwy. Reload again and it goes back to working as expected but with "Also show next layer" unchecked.
What did you expect to happen?
Based on the changelog, reloading the window should have brought back the gcode viewer with the same options checked and functional. The "center viewport" and "zoom in" options persist across reloads, which I believe is the purpose of the new functionality.
What happened instead?
All options are shown unchecked and the size warning is given underneath the gcode viewer with null values.
Did the same happen when running OctoPrint in safe mode?
Yes - I restarted in safe mode and was able to recreate the issue with the same steps. Turning on "Also show next layer" and reloading would give the issues.
Branch & Commit or Version of OctoPrint
Operating System running OctoPrint
octopi 0.13.0 - but manually updated via apt update/upgrade since install.
Printer model & used firmware incl. version
Monoprice Maker Ultimate, stock firmware
Browser and Version of Browser, Operating System running Browser
Google Chrome Version 62.0.3202.94 (Official Build) (64-bit) on OS X Sierra 10.12.6
Link to octoprint.log
Link to contents of terminal tab or serial.log
Terminal output is filled with info about the current print, so might not be pertinent. serial.log is empty (although has the message about how to enable it as per 1.3.6 RC1 feature enhancement!)
Terminal output from a "Copy all" in the terminal window:
Screenshot(s)/video(s) showing the problem:
I have read the FAQ.
referenced this issue
Dec 5, 2017
added a commit
Dec 5, 2017
Turns out that this was a bug that was always in there but never got triggered since the
Should be fixed in the next RC thanks to above commit.