New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.3.6rc1: Issue with temp offset on one tool resetting to 0 when entering one on another tool #2268

Closed
foosel opened this Issue Dec 5, 2017 · 1 comment

Comments

1 participant
@foosel
Owner

foosel commented Dec 5, 2017

To quote #2256 (comment)

I encountered one issue. Setting a temperature offset to one tool resets a previously set offset on other tools. But it appears to be only the frontend showing wrong values.

Confirmed against OctoPrint 1.3.6rc2.dev9+g743d590d

cc @malnvenshorn

@foosel foosel added this to the 1.3.6 milestone Dec 5, 2017

@foosel foosel self-assigned this Dec 5, 2017

foosel added a commit that referenced this issue Dec 5, 2017

Fix offset values on API after setting one offset
Make sure to set the actual effective offsets as provided by the comm
layer (which merges incoming single offset adjustments) instead of only
setting the input, effectively nuking return of offsets set prior.

Closes #2268

@foosel foosel added the status:solved label Dec 5, 2017

@foosel

This comment has been minimized.

Show comment
Hide comment
@foosel

foosel Dec 5, 2017

Owner

1.3.6rc2 was released earlier today which should fix this issue.

Owner

foosel commented Dec 5, 2017

1.3.6rc2 was released earlier today which should fix this issue.

@foosel foosel closed this Dec 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment