Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android login #257

Closed
josla972 opened this issue Sep 18, 2013 · 16 comments

Comments

Projects
None yet
6 participants
@josla972
Copy link

commented Sep 18, 2013

After pressing the login button using the standard android browser, as well as the firefox beta, the username and password inputs appears as expected, but as soon as I touch the username input, both inputs disappear.

@mrongen

This comment has been minimized.

Copy link

commented Sep 18, 2013

Hi josla

Android tried to zoom in. Just keep typing. Zoom out. And then select the password field..

@josla972

This comment has been minimized.

Copy link
Author

commented Sep 18, 2013

Its fully unzoomed, and still disappears as soon as I tap the username field, so I can't really input anything.

@tenaciousRas

This comment has been minimized.

Copy link

commented Sep 18, 2013

Yea - it's broken on the default Android browser and Dolphin. It looks like the touch event for the text-inputs in the dropdown is slightly off - to the lower-right by ~10px. This may or may not be related to what is apparently some unexpected bubbling of the touch event, perhaps. @foosel -- I'll send you a pull for this when I fix it...

@savorywatt

This comment has been minimized.

Copy link
Contributor

commented Sep 20, 2013

@tenaciousRas how does it perform on Chrome for Android? I can help test this/fix this weekend. @ me.

@tenaciousRas

This comment has been minimized.

Copy link

commented Sep 20, 2013

@hendricksonrw update: works best on Chrome for Android - but performs well on default and Dolphin also. It would be nice to have a mobile version that's more linear with a fullscreen login overlay.

It took a while but I think we've got it. Eventually had to surrender to web searches after scope-creep kicked in attempting to upgrade to Bootstrap3.

The fix is to delete line #766 in bootstrap.js. Per this: http://forwebonly.com/fix-for-twitter-bootstrap-dropdown-on-ipad-and-iphone/

I've tested this on an Android tablet and desktop Chrome browser - looks OK in both. Can anybody verify or should I send a pull request? It is one line...

@foosel

This comment has been minimized.

Copy link
Owner

commented Sep 20, 2013

Fyi, I've already started migration to Bootstrap 3.

@tenaciousRas

This comment has been minimized.

Copy link

commented Sep 20, 2013

If nothing else this was a great opp. for me to get my hands dirty with bootstrap. Is that already fixed? :P

@foosel

This comment has been minimized.

Copy link
Owner

commented Sep 20, 2013

I'm on a business trip at the moment and will be on a maker convention the
whole weekend, so no, it's not fixed yet ;)

@tenaciousRas

This comment has been minimized.

Copy link

commented Sep 20, 2013

Word - I merely got confused by some workspace craziness - and yes I see it isn't fixed. I'll send a pull request with screenshots.

@foosel

This comment has been minimized.

Copy link
Owner

commented Jan 5, 2014

Uhm... I'm feeling a bit stupid asking this since I definitely saw this happening a while ago myself, but -- could someone please test if this is still occurring on their end? I can login on both my tablet and my phone perfectly fine, but that only includes Chrome for Android and the Samsung browser thingy (Note 10.1).

@foosel

This comment has been minimized.

Copy link
Owner

commented Jan 5, 2014

Never mind, I found a browser in an ADK emulator with which I could reproduce this. Stock browser, Android 4.0.3

@szafran81

This comment has been minimized.

Copy link

commented Apr 14, 2014

Continuing from #439 ...

I think that's the title bars fault (the bar that holds the printers name on top of the OctoPrint GUI). The bar moves with the scope of the page when it's enlarged. In other words the X0 point of the bar stays at X0 point of the screen (and it should stay with X0 of the page instead). I think that the login box is always visible - just out of scope of view.

@foosel foosel added status:accepted and removed type:bug labels Jul 27, 2014

foosel added a commit that referenced this issue Aug 7, 2014

Made the navbar static instead of fixed to improve usability on mobil…
…e devices

This is just a hack really, the proper approach would be to finally move to a real responsive design, but this should prove as a valid workaround until that is realized.

Closes #257 for now.
@foosel

This comment has been minimized.

Copy link
Owner

commented Aug 7, 2014

@szafran81 that was a valuable hint, you were right. I changed the navbar to navbar-static-top now, so it doesn't scroll with the content anymore. Doesn't make that much of a difference on desktops (and probably tablets, but mine's out of juice right now so I couldn't test yet), but should make everything way more usable on phones.

The proper solution would be to finally introduce a real responsive design (responsive in that case meaning "adaptive to screen size", not "reacts like a desktop app" :P), but since that's a lot of work that will take its time this is a suitable workaround for now.

Closing this.

@foosel foosel closed this Aug 7, 2014

@szafran81

This comment has been minimized.

Copy link

commented Aug 7, 2014

Confirmed. Works fine on my phone. Thank you.

@foosel

This comment has been minimized.

Copy link
Owner

commented Aug 7, 2014

\o/

foosel added a commit that referenced this issue Aug 8, 2014

Made the navbar static instead of fixed to improve usability on mobil…
…e devices

This is just a hack really, the proper approach would be to finally move to a real responsive design, but this should prove as a valid workaround until that is realized.

Closes #257 for now.
(cherry picked from commit 02212bd)

foosel added a commit that referenced this issue Aug 8, 2014

Made the navbar static instead of fixed to improve usability on mobil…
…e devices

This is just a hack really, the proper approach would be to finally move to a real responsive design, but this should prove as a valid workaround until that is realized.

Closes #257 for now.
(cherry picked from commit 02212bd)
@josla972

This comment has been minimized.

Copy link
Author

commented Aug 9, 2014

Cherry picked the commit (I am using the master branch for stability reasons). Works much better. Thank you! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.