New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RC Feedback] Feedback on the 1.3.10rc3 Release Candidate #2917

Closed
foosel opened this Issue Nov 28, 2018 · 16 comments

Comments

10 participants
@foosel
Owner

foosel commented Nov 28, 2018

Please provide general feedback on your experience with the 1.3.10rc3 Release Candidate here. An "All is working fine" is valuable feedback as well, because it tells me that people in fact are testing the RC and just not finding any problems. Thanks :)

If you run into any obvious bugs not yet listed below the following line, please open a new ticket and follow "How to file a bug report".


Currently known bugs

Unreproduced

none

Unreproduced and lacking necessary information to look into, awaiting full bug report

@benlye

This comment has been minimized.

Contributor

benlye commented Nov 28, 2018

I can confirm that the current version (v1.0.0) of the Firmware Updater plugin works with RC3 👍

When I've more time I'll make necessary changes to use CommandLineCaller wrapper instead of invoking Sarge directly.

@ChrisHeerschap

This comment has been minimized.

ChrisHeerschap commented Nov 28, 2018

RC2 has been working well for me with the exception that the fantastic Exclude Region plugin stopped working - see bradcfisher/OctoPrint-ExcludeRegionPlugin#15 (comment) - just tested with RC3 and it looks like it's still broken. Plugin maintainer is aware and investigating, don't know if you can provide any helpful feedback.

Running a test print in RC3 and will do the usual click-around-and-look-for-any-issues.

@skohls

This comment has been minimized.

skohls commented Nov 28, 2018

Using RC3 on the first print, so far w/o problems.
I installed the development version of the Exclude Region plugin and this seems to work now as well... (at least I can create areas, modify them etc.)
https://github.com/bradcfisher/OctoPrint-ExcludeRegionPlugin/archive/devel.zip

@tteckenburg

This comment has been minimized.

tteckenburg commented Nov 28, 2018

Hi Gina,

still dinglish... i only keep the firmware for testing ;-)

image

@foosel

This comment has been minimized.

Owner

foosel commented Nov 28, 2018

ARGH. If that's the only thing in RC3 though, it'll stay ;)

I made it translatable, I added a translation, I have no idea right now why it's not being applied. 🤷‍♀️

@ChrisHeerschap

This comment has been minimized.

ChrisHeerschap commented Nov 28, 2018

I think it's way more attention getting in German, though. 😆

@ChrisHeerschap

This comment has been minimized.

ChrisHeerschap commented Nov 28, 2018

Test print ran fine, clicked around everything I could think of, looking good!

@kmanley57

This comment has been minimized.

kmanley57 commented Nov 29, 2018

Tried on a couple Lulzbot printers without a single problem so far. Great work!

@bradcfisher

This comment has been minimized.

Contributor

bradcfisher commented Nov 29, 2018

I released a new version (0.1.3) of the Exclude Region plugin to address the issues it had with the 1.3.10 release candidates as reported by @ChrisHeerschap. The behavior was not due to anything wrong in OctoPrint, and was a result of how the plugin was detecting Gcode viewer enhancements that were added in the 1.3.10 releases.

@JohnOCFII

This comment has been minimized.

JohnOCFII commented Nov 29, 2018

Upgrade from rc2 to rc3 went well. I completed a 3.5 hour print to a Prusa MK3 running (slightly older) firmware 3.4.0.

  • Timelapse worked fine.
  • Print History plugin worked fine.
  • OctoSlack plugin worked fine.
  • Telegram plugin worked fine.
@Goodeid

This comment has been minimized.

Goodeid commented Nov 30, 2018

The upgrade from rc2 to rc3 was perfect and after numerous prints with both versions there is only one thing that is missing and one anomaly..
You removed the "printed" and :visited" layer display in the Gcode Viewer and I understand the confusion that some people had with them. But I sure miss the "printed" layer display as it was directly above the "Layer Number" and the two provided a quick. simple progress indication.
Second the "Approx Total Print Time" in the State area does not match the "Estimated total print time" on the Gcode Viewer tab. I realize that these are only approximations, but should they not be the same?

@foosel

This comment has been minimized.

Owner

foosel commented Nov 30, 2018

You removed the "printed" and :visited" layer display in the Gcode Viewer and I understand the confusion that some people had with them. But I sure miss the "printed" layer display as it was directly above the "Layer Number" and the two provided a quick. simple progress indication.

It was simply causing confusion too often, sorry.

Second the "Approx Total Print Time" in the State area does not match the "Estimated total print time" on the Gcode Viewer tab. I realize that these are only approximations, but should they not be the same?

image

Yes and no. They are different implementations, so there can be a difference in the result. It might make sense to remove the GCODE version in a future version and replace it with the server side estimate, however then the layer estimates would no longer add up.

@Goodeid

This comment has been minimized.

Goodeid commented Nov 30, 2018

Regarding the "printed" and "visited" layers I fully understand the confusion they caused. I was hoping that the "printed layers" display could return without the "visited layers" portion of the line.

@foosel

This comment has been minimized.

Owner

foosel commented Nov 30, 2018

@Goodeid how about this, open a feature request and I can see what I can do for 1.3.11 if it looks like there are other people interested in that as well 🙂 For 1.3.10 it's too late though, I really don't want to reopen things like that at this point.

@tteckenburg since I'll have to do a fourth RC anyhow, I looked into that firmware warning denglish and it will be fixed in 1.3.10rc4 ;) See 89469d3 and:

image

@andrivet

This comment has been minimized.

andrivet commented Dec 1, 2018

Confirm also that Firmware Updater plugin works with RC3. Updating RC2 to RC3 went well.

@foosel

This comment has been minimized.

Owner

foosel commented Dec 3, 2018

1.3.10rc4 is out, new ticket is here: #2939

@foosel foosel closed this Dec 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment