Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/api/printer/tool doesn't detect invalid tool parameters if they aren't strings #3092

Closed
sentry-io bot opened this issue Mar 28, 2019 · 1 comment

Comments

Projects
None yet
1 participant
@sentry-io
Copy link

commented Mar 28, 2019

Problem

Sentry Issue: SERVER-28

TypeError: expected string or buffer
(5 additional frame(s) were not displayed)
...
  File "octoprint/server/util/flask.py", line 1245, in decorated_view
    return no_firstrun_access(flask_login.login_required(func))(*args, **kwargs)
  File "octoprint/server/util/flask.py", line 1264, in decorated_view
    return func(*args, **kwargs)
  File "flask_login.py", line 758, in decorated_view
    return func(*args, **kwargs)
  File "octoprint/server/api/printer.py", line 83, in printerToolCommand
    if re.match(validation_regex, tool) is None:
  File "re.py", line 141, in match
    return _compile(pattern, flags).match(string)

Exception on /api/printer/tool [POST]

Caller provided an integer as tool.

@foosel

This comment has been minimized.

Copy link
Owner

commented Apr 4, 2019

1.3.11rc2 was just released

@foosel foosel closed this Apr 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.