Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.3.11rc2] Refactoring error in port detection causing exception if port cannot enter programming mode #3108

Closed
sentry-io bot opened this issue Apr 5, 2019 · 2 comments

Comments

Projects
None yet
2 participants
@sentry-io
Copy link

commented Apr 5, 2019

Sentry Issue: SERVER-TV

NameError: global name 'e' is not defined
  File "octoprint/util/comm.py", line 2603, in _openSerial
    serial_obj = factory(self, self._port, self._baudrate, settings().getFloat(["serial", "timeout", "connection"]))
  File "octoprint/util/comm.py", line 2573, in default
    port = self._detect_port()
  File "octoprint/util/comm.py", line 2558, in _detect_port
    self._logger.info("Could not enter programming mode on {}: {}".format(p, e))

Unexpected error while connecting to serial port: AUTO NameError: 'global name 'e' is not defined' @ comm.py:_openSerial:2603 (hook default)

foosel added a commit that referenced this issue Apr 5, 2019

@foosel foosel added this to the 1.3.11 milestone Apr 5, 2019

Repository owner deleted a comment from GitIssueBot Apr 5, 2019

@foosel foosel removed their assignment Apr 5, 2019

@foosel

This comment has been minimized.

Copy link
Owner

commented Apr 5, 2019

Fix ready for 1.3.11rc3

@foosel

This comment has been minimized.

Copy link
Owner

commented Apr 11, 2019

1.3.11rc3 is out which should fix this.

@foosel foosel closed this Apr 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.