Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.3.12rc1] GCODE viewer shows wrong layer #3272

Closed
foosel opened this issue Sep 16, 2019 · 1 comment

Comments

@foosel
Copy link
Owner

commented Sep 16, 2019

Problem

As reported here, the GCODE viewer shows the wrong layer during a print. Regression, introduced by c1e8bc7.

The reason is that the percentage-to-layer map is built on the whole model, the renderer however only has a filtered copy of the data now. This makes things go out of sync as long as "Hide empty layers" and "Sort layers" are selected in advanced options.

For the same reason the layer slider shows a wrong number of layers.

Solution

Adjust lookup and layer slider to retrieve data from filtered model instead of full model.

@foosel foosel added this to the 1.3.12 milestone Sep 16, 2019
foosel added a commit that referenced this issue Sep 16, 2019
foosel added a commit that referenced this issue Sep 16, 2019
Now with all files...

Fixes #3272
@foosel

This comment has been minimized.

Copy link
Owner Author

commented Sep 17, 2019

1.3.12rc2 is released.

@foosel foosel closed this Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.