Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.3.12rc2] GCODE viewer: cloneDeep eats way too much memory on anything but simple models #3277

Closed
foosel opened this issue Sep 18, 2019 · 1 comment

Comments

@foosel
Copy link
Owner

commented Sep 18, 2019

Problem

Deep cloning the whole GCODE model in order to avoid issues with regards to accidentally filtered layers turns out to be a decidedly bad idea as it will increase memory consumption in a quite drastic way, leading to models no longer rendering on regular hardware that before had no issues.

See also #3275 (comment)

Solution

Since we only do manipulation of the model on layer filtering and ordering level, we can get away with simply creating shallow copies with rearranged/filtered layers. No need to do a full deep copy.

@foosel foosel added this to the 1.3.12 milestone Sep 18, 2019
foosel added a commit that referenced this issue Sep 18, 2019
Fixes #3277
@foosel

This comment has been minimized.

Copy link
Owner Author

commented Sep 23, 2019

1.3.12rc3 is out

@foosel foosel closed this Sep 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.