Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RC Feedback] Feedback on the 1.4.0rc2 Release Candidate #3360

Open
foosel opened this issue Dec 2, 2019 · 12 comments

Comments

@foosel
Copy link
Owner

@foosel foosel commented Dec 2, 2019

Please provide general feedback on your experience with the 1.4.0rc2 Release Candidate here. An "All is working fine" is valuable feedback as well, because it tells me that people in fact are testing the RC and just not finding any problems. Thanks :)

If you run into any obvious bugs not yet listed below the following line, please open a new ticket and follow "How to file a bug report".


Currently known issues

  • 🐛#3365: global API KEY don't have all permission - fix ready for 1.4.0rc3
  • 🐛#3366: Appkeys request returns 500/Internal server error - fix ready for 1.4.0rc3
  • ☔✔ #3367: UI fails to load due to MIME type issues under Windows 10 - workaround ready for 1.4.0rc3

Unreproduced issues

Unreproduced and information for further analysis missing

Unrelated third party plugin issues

@ChrisHeerschap

This comment has been minimized.

Copy link

@ChrisHeerschap ChrisHeerschap commented Dec 2, 2019

Loaded up and used rc1 - noticed 502 errors when sending prints from Cura using the API but that's fixed now. I think there was something else I noticed but can't remember for the life of me. My current plugins seem fine and I've done several prints with no issues. Well, I mean the prints themselves had issues but pretty sure that's my fault, or the printer's.

Update: I'm using octoslack plugin and I don't get a print finished message. Do get a print started. I think this is new to 1.4.0 but I have done absolutely nothing to diagnose this so don't worry about it quite yet. I'll post once I've done anything useful.

@foosel foosel pinned this issue Dec 2, 2019
@devildant

This comment has been minimized.

Copy link
Contributor

@devildant devildant commented Dec 2, 2019

Hello @foosel ,

I use API Key present in the API section inside custom python scripts (http) to trigger events on my plugins ...
but since the transition to the RC2 I systematically get error 403
(I did not create an issue, because I'm not sure that it's a bug)

@devildant

This comment has been minimized.

Copy link
Contributor

@devildant devildant commented Dec 2, 2019

the global key should have all the authorization, right?

@foosel

This comment has been minimized.

Copy link
Owner Author

@foosel foosel commented Dec 2, 2019

It should, yes. Please open an issue.

@devildant

This comment has been minimized.

Copy link
Contributor

@devildant devildant commented Dec 2, 2019

@foosel , it's open : #3365

@kazibole

This comment has been minimized.

Copy link

@kazibole kazibole commented Dec 4, 2019

@ChrisHeerschap

Update: I'm using octoslack plugin and I don't get a print finished message. Do get a print started. I think this is new to 1.4.0 but I have done absolutely nothing to diagnose this so don't worry about it quite yet. I'll post once I've done anything useful.

Do your Slack messages without snapshots succeed, and those with snapshots fail? I ran into this issue, see fraschetti/Octoslack#71.

@gege2b

This comment has been minimized.

Copy link

@gege2b gege2b commented Dec 4, 2019

Hi
I upgraded the RC2 yesterday, and right after the upgrade, there was a bunch full of errors (UI was cluttered in all ways. I cleared the cache and then all was fine as far as I can tell
I still ran accros an issue mentionned here but not octoprint related

I also got something certainly related to #3365 (with Octolapse showing me it didn't had the permission to load settings)
image
image

EDIT
And finally, right now, I see that the file list isn't populated (it was yesterday after the upgrade)
Note : it's OK now after some hard refresh, I keep the folowing informations for the record :

Even if files are listed, I can't open/print them anymore

2019-12-04 11:49:33,119 - tornado.access - WARNING - 403 POST /api/files/local/20191204-091625-Hinge_arm_-_long_6x_0.2-15-.gcode (192.168.1.129) 56.24ms

image

2019-12-04 09:35:48,965 - octoprint.server.util.sockjs - INFO - Client connection closed: fe80::89f3:31bb:ced0:2093%wlan0
2019-12-04 09:35:56,901 - octoprint.server.util.sockjs - INFO - New connection from client: fe80::89f3:31bb:ced0:2093%wlan0
2019-12-04 09:35:57,175 - octoprint.server.util.flask - INFO - Passively logging in user gege from 192.168.1.129
2019-12-04 09:35:58,037 - octoprint.plugins.cancelobject - INFO - No active object id!
2019-12-04 09:35:58,324 - tornado.access - WARNING - 403 GET /api/access/groups (fe80::89f3:31bb:ced0:2093%wlan0) 28.72ms
2019-12-04 09:35:58,449 - tornado.access - WARNING - 403 GET /api/printerprofiles (fe80::89f3:31bb:ced0:2093%wlan0) 114.33ms
2019-12-04 09:35:58,489 - tornado.access - WARNING - 403 GET /api/system/commands (fe80::89f3:31bb:ced0:2093%wlan0) 28.42ms
2019-12-04 09:35:58,526 - tornado.access - WARNING - 403 GET /plugin/announcements/channels (fe80::89f3:31bb:ced0:2093%wlan0) 26.55ms
2019-12-04 09:35:58,566 - tornado.access - WARNING - 403 GET /api/printer/command/custom (fe80::89f3:31bb:ced0:2093%wlan0) 28.98ms
2019-12-04 09:35:58,620 - tornado.access - WARNING - 403 GET /api/plugin/pluginmanager (fe80::89f3:31bb:ced0:2093%wlan0) 43.22ms
2019-12-04 09:35:58,661 - tornado.access - WARNING - 403 GET /api/plugin/printer_safety_check (fe80::89f3:31bb:ced0:2093%wlan0) 30.16ms
2019-12-04 09:35:58,698 - tornado.access - WARNING - 403 GET /plugin/softwareupdate/check (fe80::89f3:31bb:ced0:2093%wlan0) 25.82ms
2019-12-04 09:35:58,738 - tornado.access - WARNING - 403 GET /api/files?recursive=true (fe80::89f3:31bb:ced0:2093%wlan0) 29.26ms
2019-12-04 09:35:58,771 - octoprint.server.api - ERROR - Error calling SimpleApiPlugin action_command_prompt
Traceback (most recent call last):
  File "/home/pi/OctoPrint/venv/local/lib/python2.7/site-packages/octoprint/server/api/__init__.py", line 70, in pluginData
    response = api_plugin.on_api_get(request)
  File "/home/pi/OctoPrint/venv/lib/python2.7/site-packages/octoprint/plugins/action_command_prompt/__init__.py", line 124, in on_api_get
    return flask.abort(403, "Insufficient permissions")
  File "/home/pi/OctoPrint/venv/local/lib/python2.7/site-packages/werkzeug/exceptions.py", line 772, in abort
    return _aborter(status, *args, **kwargs)
  File "/home/pi/OctoPrint/venv/local/lib/python2.7/site-packages/werkzeug/exceptions.py", line 753, in __call__
    raise self.mapping[code](*args, **kwargs)
Forbidden: 403 Forbidden: Insufficient permissions
2019-12-04 09:35:59,039 - tornado.access - ERROR - 500 GET /api/plugin/action_command_prompt (fe80::89f3:31bb:ced0:2093%wlan0) 288.91ms
2019-12-04 09:35:59,791 - tornado.access - WARNING - 403 GET /api/slicing (192.168.1.129) 31.45ms
2019-12-04 09:35:59,846 - tornado.access - WARNING - 403 POST /plugin/octolapse/loadSettings (192.168.1.129) 43.49ms
2019-12-04 09:35:59,854 - octoprint.server.util.sockjs - INFO - User gege logged in on the socket from client fe80::89f3:31bb:ced0:2093%wlan0
2019-12-04 09:36:11,564 - octoprint.plugins.navbartemp - INFO - Checking SoC internal temperature
2019-12-04 09:36:41,630 - octoprint.plugins.navbartemp - INFO - Checking SoC internal temperature
2019-12-04 09:36:57,560 - tornado.access - WARNING - 403 GET /api/files?recursive=true&force=true (fe80::89f3:31bb:ced0:2093%wlan0) 39.05ms
2019-12-04 09:37:11,694 - octoprint.plugins.navbartemp - INFO - Checking SoC internal temperature
2019-12-04 09:37:17,716 - octoprint.server.util.sockjs - INFO - Client connection closed: fe80::89f3:31bb:ced0:2093%wlan0
2019-12-04 09:37:30,380 - octoprint.server.util.sockjs - INFO - New connection from client: fe80::89f3:31bb:ced0:2093%wlan0
2019-12-04 09:37:30,671 - octoprint.server.util.flask - INFO - Passively logging in user gege from 192.168.1.129
2019-12-04 09:37:32,451 - octoprint.plugins.cancelobject - INFO - No active object id!
2019-12-04 09:37:32,728 - tornado.access - WARNING - 403 GET /api/access/groups (fe80::89f3:31bb:ced0:2093%wlan0) 29.44ms
2019-12-04 09:37:32,855 - tornado.access - WARNING - 403 GET /api/printerprofiles (fe80::89f3:31bb:ced0:2093%wlan0) 116.39ms
2019-12-04 09:37:32,896 - tornado.access - WARNING - 403 GET /api/system/commands (fe80::89f3:31bb:ced0:2093%wlan0) 29.42ms
2019-12-04 09:37:32,933 - tornado.access - WARNING - 403 GET /plugin/announcements/channels (fe80::89f3:31bb:ced0:2093%wlan0) 27.27ms
2019-12-04 09:37:32,977 - tornado.access - WARNING - 403 GET /api/slicing (fe80::89f3:31bb:ced0:2093%wlan0) 32.32ms
2019-12-04 09:37:33,015 - tornado.access - WARNING - 403 GET /api/printer/command/custom (fe80::89f3:31bb:ced0:2093%wlan0) 27.54ms
2019-12-04 09:37:33,056 - tornado.access - WARNING - 403 GET /api/plugin/printer_safety_check (fe80::89f3:31bb:ced0:2093%wlan0) 31.81ms
2019-12-04 09:37:33,097 - tornado.access - WARNING - 403 GET /api/files?recursive=true (fe80::89f3:31bb:ced0:2093%wlan0) 30.56ms
2019-12-04 09:37:33,127 - octoprint.server.api - ERROR - Error calling SimpleApiPlugin action_command_prompt
Traceback (most recent call last):
  File "/home/pi/OctoPrint/venv/local/lib/python2.7/site-packages/octoprint/server/api/__init__.py", line 70, in pluginData
    response = api_plugin.on_api_get(request)
  File "/home/pi/OctoPrint/venv/lib/python2.7/site-packages/octoprint/plugins/action_command_prompt/__init__.py", line 124, in on_api_get
    return flask.abort(403, "Insufficient permissions")
  File "/home/pi/OctoPrint/venv/local/lib/python2.7/site-packages/werkzeug/exceptions.py", line 772, in abort
    return _aborter(status, *args, **kwargs)
  File "/home/pi/OctoPrint/venv/local/lib/python2.7/site-packages/werkzeug/exceptions.py", line 753, in __call__
    raise self.mapping[code](*args, **kwargs)
Forbidden: 403 Forbidden: Insufficient permissions
2019-12-04 09:37:33,337 - tornado.access - ERROR - 500 GET /api/plugin/action_command_prompt (fe80::89f3:31bb:ced0:2093%wlan0) 229.39ms
2019-12-04 09:37:33,950 - tornado.access - WARNING - 403 GET /api/plugin/pluginmanager (fe80::89f3:31bb:ced0:2093%wlan0) 28.20ms
2019-12-04 09:37:33,989 - tornado.access - WARNING - 403 GET /plugin/softwareupdate/check (fe80::89f3:31bb:ced0:2093%wlan0) 27.79ms
2019-12-04 09:37:34,030 - octoprint.server.util.sockjs - INFO - User gege logged in on the socket from client fe80::89f3:31bb:ced0:2093%wlan0
2019-12-04 09:37:34,403 - tornado.access - WARNING - 403 POST /plugin/octolapse/loadSettings (192.168.1.129) 56.97ms
2019-12-04 09:37:41,756 - octoprint.plugins.navbartemp - INFO - Checking SoC internal temperature
2019-12-04 09:37:50,703 - octoprint.server.heartbeat - INFO - Server heartbeat <3
2019-12-04 09:38:05,263 - octoprint.plugins.tracking - INFO - Sent tracking event ping, payload: {'octoprint_uptime': 78308}
2019-12-04 09:38:11,816 - octoprint.plugins.navbartemp - INFO - Checking SoC internal temperature
2019-12-04 09:38:41,878 - octoprint.plugins.navbartemp - INFO - Checking SoC internal temperature
2019-12-04 09:39:11,940 - octoprint.plugins.navbartemp - INFO - Checking SoC internal temperature
@foosel

This comment has been minimized.

Copy link
Owner Author

@foosel foosel commented Dec 4, 2019

@gege2b does the same thing happen in safe mode? Please open a full ticket.

@gege2b

This comment has been minimized.

Copy link

@gege2b gege2b commented Dec 4, 2019

No It doesn't, but it was not easy to restart it in safe mode :)
I'll open a new ticket

@ChrisHeerschap

This comment has been minimized.

Copy link

@ChrisHeerschap ChrisHeerschap commented Dec 4, 2019

Do your Slack messages without snapshots succeed, and those with snapshots fail? I ran into this issue, see fraschetti/Octoslack#71.

Yes! Thanks you! Work has had me troubleshooting boring stuff so i haven't been able to look at this yet. Disabled snapshots and alerts work again. One for the "Unrelated third party plugin issues", I think.

@krpepe

This comment has been minimized.

Copy link

@krpepe krpepe commented Dec 5, 2019

Thank you for all of your hard work!

The program works awesome as usual. The only very minor issue I have found so far is, I upload a file from simplify3d to the watched folder and print it. If I want to print that same file a second time the print button is grayed out and will not allow me to select it to print. I have tried sending the file and overwriting the one in the watched folder with no success. I have to delete the file from the watched folder and resend it. Has to be a fresh file to be printed. Same goes if you cancel a file. This is not a huge issue for me. I am just wondering if this is expected behavior or if I am doing something wrong.

Thank you in advance,
Kevin

Raspberry pi 3b
simplify3d
windows 10
Klipper firmware

@BerndJM

This comment has been minimized.

Copy link

@BerndJM BerndJM commented Dec 5, 2019

I wrote a small plugin that cloned the custom controls to the temp-tab.
Unfortunately this doesn't work with the 1.4.0rc2 anymore (with the 1.3.12 it works fine).
When I write console.log commands to the .js I see that it is running but apparently the div-container (.custom_section) does not exist yet.
If I try the parent container (#control-jog-custom) this will be cloned but empty.
I tried using onStartupComplete instead of onAllBound to move the execution to a later point, but the result is the same.
If I execute the line for cloning after startup from the browser console, the buttons will be cloned without problems.
Bug? Feature? or am I missing something?

clone_custom_buttons.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.