Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.4.0rc2] rolling_window size is not an integer, serial loop crash #3371

Closed
Lantoit opened this issue Dec 5, 2019 · 3 comments
Closed

[1.4.0rc2] rolling_window size is not an integer, serial loop crash #3371

Lantoit opened this issue Dec 5, 2019 · 3 comments

Comments

@Lantoit
Copy link

@Lantoit Lantoit commented Dec 5, 2019

#2651 What were you doing?

Trying to print from SD
I've selected a file and octoprint report

"There was an unknown error while talking to your printer. Please consult the terminal output and octoprint.log for details. Error: See octoprint.log for details"

If you encountered a problem with specific files of any sorts, make sure
to also include a link to a file with which to reproduce the problem.

What did you expect to happen?

Print from SD

What happened instead?

Error

Did the same happen when running OctoPrint in safe mode?

Same error

Version of OctoPrint

OctoPrint 1.4.0rc2 running on OctoPi 0.17.0 

Operating System running OctoPrint

on OctoPi 0.17.0

Printer model & used firmware incl. version

Sharebot with Marlin 1.0.x upgraded yesterday

Browser and version of browser, operating system running browser

Ubuntu 19.10 + Firefox

Link to octoprint.log

Link to contents of terminal tab or serial.log

serial.log.2019-12-05_18-34-19.log
serial.log.2019-12-05_18-37-36.log

@Lantoit

This comment has been minimized.

Copy link
Author

@Lantoit Lantoit commented Dec 5, 2019

@foosel

This comment has been minimized.

Copy link
Owner

@foosel foosel commented Dec 6, 2019

Thanks, that indeed looks like there's still a bug in there.

Stack trace:

2019-12-05 18:37:36,778 - octoprint.util.comm - ERROR - Something crashed inside the serial connection loop, please report this in OctoPrint's bug tracker:
Traceback (most recent call last):
  File "/home/pi/oprint/lib/python3.7/site-packages/octoprint/util/comm.py", line 2111, in _monitor
    user=self._currentFile.getUser())
  File "/home/pi/oprint/lib/python3.7/site-packages/octoprint/printer/standard.py", line 1171, in on_comm_file_selected
    self._create_estimator()
  File "/home/pi/oprint/lib/python3.7/site-packages/octoprint/printer/standard.py", line 158, in _create_estimator
    self._estimator = self._estimator_factory(job_type)
  File "/home/pi/oprint/lib/python3.7/site-packages/octoprint/printer/estimation.py", line 46, in __init__
    self._data = TimeEstimationHelper(rolling_window=rolling_window, countdown=countdown, threshold=threshold)
  File "/home/pi/oprint/lib/python3.7/site-packages/octoprint/printer/estimation.py", line 190, in __init__
    self._distances = collections.deque([], self._rolling_window)
TypeError: an integer is required
@foosel foosel added this to the 1.4.0 milestone Dec 6, 2019
foosel added a commit that referenced this issue Dec 6, 2019
@foosel foosel added the status:solved label Dec 6, 2019
@foosel foosel changed the title octoprint.util.comm - ERROR - Something crashed inside the serial connection loop [1.4.0rc2] rolling_window size is not an integer, serial loop crash Dec 6, 2019
@foosel

This comment has been minimized.

Copy link
Owner

@foosel foosel commented Dec 12, 2019

1.4.0rc3 has just been released

@foosel foosel closed this Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.