Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.4.0rc2] extruder control visible without control permission #3388

Closed
foosel opened this issue Dec 11, 2019 · 1 comment
Closed

[1.4.0rc2] extruder control visible without control permission #3388

foosel opened this issue Dec 11, 2019 · 1 comment
Assignees
Milestone

Comments

@foosel
Copy link
Owner

@foosel foosel commented Dec 11, 2019

Problem

I notice when I remove the 'control' permission, control is removed for everything but the > extruder.

I have access control on and you have to login to see anything. I removed control from the users group. Created a printer user group with printer control permissions.

image

Originally posted by @dragonflybog in #3360 (comment)

Problem seems to be data-bind="visible: loginState.hasPermissionKo(access.permissions.CONTROL) && tools().length > 0". hasPermissionKO is a computed and as such we need to call it in a function body. Needs to be checked all over the source, there might be more mistakes like this.

@foosel foosel added this to the 1.4.0 milestone Dec 11, 2019
@foosel foosel self-assigned this Dec 11, 2019
foosel added a commit that referenced this issue Dec 11, 2019
Closes #3388
@foosel

This comment has been minimized.

Copy link
Owner Author

@foosel foosel commented Dec 12, 2019

1.4.0rc3 has just been released

@foosel foosel closed this Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.