Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] Get confirmation before canceling a job #687

Closed
foofoodog opened this issue Dec 19, 2014 · 7 comments

Comments

Projects
None yet
7 participants
@foofoodog
Copy link

commented Dec 19, 2014

How about if someone clicks the cancel job button you confirm they actually want to cancel the job?
Say a dialog that says something like "You are {{elapsedTime}} into printing a job on printer {{printerName}} for file {{filename}} with {{remainder}} left. Are you sure you want to cancel?

e.g.
"You are 10 hours into printing a job on printer 3DMetlalDust for file Darth_Helmet.gcode with 1 hours left. Are you sure you want to cancel?"

I love cookies made from PLA.

@foosel foosel added the type:request label Dec 19, 2014

@smartroad

This comment has been minimized.

Copy link

commented Dec 29, 2014

As long as there is the option to not have it (in settings). I have had to use it from time to time when something went really wrong with a print and could do without the additional delay.

@AlaskanShade

This comment has been minimized.

Copy link

commented Jan 12, 2015

The disconnect button could use a confirmation as well. I was checking my printer from my phone and it initially came up with the connection lost dialog. When I went to hit the reconnect button, the dialog disappeared and I ended up hitting the disconnect button instead. I tinkered with how to resume the print (without luck), but it turned out I wanted to resize it anyway so I gave up.

@shanselman

This comment has been minimized.

Copy link

commented Feb 6, 2015

Yes, I'd definitely be in favor of more confirmations or at least the option to turn them all on, per #748. I deleted a nice Timelapse because the button is so close to download.

@fieldOfView

This comment has been minimized.

Copy link
Contributor

commented Oct 22, 2015

As long as there is the option to not have it (in settings).

In settings, and/or as a "Don't show this confirmation again" checkbox

@foosel

This comment has been minimized.

Copy link
Owner

commented Dec 18, 2016

Just now realized we had a duplicate of that with #1550 which has since been implemented in 1.3.0. Also that's going to be made optional again with 1.3.1 (see #1638) since of course now there is a confirmation dialog the other half of the user base is complaining about this fact. Hooray ;)

@foosel foosel closed this Dec 18, 2016

@BillyBlaze

This comment has been minimized.

Copy link
Collaborator

commented Dec 18, 2016

Just my two cents on this matter; isn't it better if we would refactor the showConfirmationDialog function with the notification component (PNotify) instead of a modal? I think that would also be more consistent with features such as the update confirmation, perhaps it's also less invasive.

(Perhaps it would be also a good idea to move the settings check within that function, so its only declared once)

@foosel

This comment has been minimized.

Copy link
Owner

commented Dec 18, 2016

Imho a modal reflects "I need a decision from you right now and can't continue until I have that" better than the "oh, btw..." style of the notifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.