Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autoscroll always on #735

Closed
braddo99 opened this issue Jan 21, 2015 · 5 comments

Comments

Projects
None yet
5 participants
@braddo99
Copy link

commented Jan 21, 2015

There is an autoscroll toggle button on the terminal window which does not appear to do anything. Checked or unchecked my console scrolls commands continuously. This makes it quite difficult to copy paste out of the console, which I find helpful to do when calibrating my bot. As soon as a scroll happens, the selected content becomes unselected and hence uncopyable.

I'm running on raspberry pi (octopi) and client is Chrome on Windows7

@GitIssueBot

This comment has been minimized.

Copy link
Collaborator

commented Jan 21, 2015

Hi @braddo99,

It looks like there is some information missing from your ticket that will be needed in order to process it properly. Please take a look at the Contribution Guidelines and the page How to file a bug report on the project wiki, which will tell you exactly what your ticket has to contain in order to be processable.

If you did not intend to report a bug, please take special note of the title format to use as described in the Contribution Guidelines.

I'm marking this one now as needing some more information. Please understand that if you do not provide that information within the next two weeks (until 2015-02-04 17:40) I'll close this ticket so it doesn't clutter the bug tracker.

Best regards,
~ Your friendly GitIssueBot

PS: I'm just an automated script, not a human being.

@derpicknicker1

This comment has been minimized.

Copy link
Contributor

commented Jan 21, 2015

I think it works like it should. If autoscroll is enabled, the terminal will always jump to the last line on receiving a message. If Autoscroll is disabled, it will not jump to last line. But because there will be new lines on stack, the lines will move.

@braddo99

This comment has been minimized.

Copy link
Author

commented Jan 21, 2015

Mmm, well if the lines move at all then one is unable to accurately select content to copy from the terminal stack. I see what you are saying, but if you are already at the last line, the behavior would be identical with or without autoscroll right? Then, if in autoscroll off, you manually scroll back, the lines will continue to move at the same rate. I really don't see any positives of the current behavior but do see negatives.

@Renha

This comment has been minimized.

Copy link
Contributor

commented Jan 22, 2015

@derpicknicker1, you are right about enabled Autoscroll, but with Autoscroll disabled it will jump, just not to last line. It is not logical, position must be constant from beginning of terminal, not from end, user doesn't care about stacks or registers etc.

foosel added a commit that referenced this issue Feb 24, 2015

Improved behaviour of terminal window
  * Disabling autoscrolling now also stops cutting of the log while it's enabled, effectively preventing log lines from being modified at all
  * Applying filters displays "[...]" where lines where removed
  * Added a link to scroll to the end of the terminal log (useful for when autoscroll is disabled)
  * Added a link to select all current contents of the terminal log for easy copy-pasting
  * Added a display of how many lines are displayed, how many are filtered and how many are available in total

Closes #735
@foosel

This comment has been minimized.

Copy link
Owner

commented Feb 24, 2015

Implemented in devel. And now please someone explain to me what else I have to do to get you people to read and adhere to the bloody contribution and bug report guidelines...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.