Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCode Viewer Size Override Not Working #825

Closed
eboston opened this issue Mar 25, 2015 · 17 comments

Comments

Projects
None yet
4 participants
@eboston
Copy link

commented Mar 25, 2015

  1. What were you doing?
    Selecting GCode Viewer tab with a large print file.
  2. What did you expect to happen?
    After getting the warning about the file size and clicking the visualize regardless of size button, for the GCode Viewer to show the visualization. Either that or for the browser to lock-up as stated in the warning.
  3. What happened instead?
    The blank visualization screen is shown then it goes back to the warning message.
  4. Branch & Commit or Version of OctoPrint:
    Version: 1.2.0-dev-668-g3ebd54d (devel branch)
  5. Printer model & used firmware incl. version
    (if applicable - always include if unsure):
    Printrbot Simple Metal
  6. Browser and Version of Browser, Operating
    System running Browser (if applicable - always
    include if unsure):
    Chrome v41.0.2272.101 m
  7. Link to octoprint.log on gist.github.com or pastebin.com:
    Nothing was shown in the log
  8. Link to contents of terminal tab or serial.log on
    gist.github.com or pastebin.com (if applicable - always
    include if unsure or reporting communication issues):
    Nothing shown in the terminal tab
  9. Link to contents of Javascript console in the browser
    on gist.github.com or pastebin.com or alternatively a
    screenshot (if applicable - always include if unsure
    or reporting UI issues):
    No errors were displayed in the javascript console.
  10. Screenshot(s) showing the problem (if applicable - always
    include if unsure or reporting UI issues):
    N/A

I have read the FAQ.

This same behavior is seen on my mobile devices and desktop browsers.

@cscott

This comment has been minimized.

Copy link

commented Apr 2, 2015

I'm seeing this, too.

@Grifplex

This comment has been minimized.

Copy link

commented Apr 8, 2015

octoprintgcodeviewererror
I'm also seeing this in Chrome as well as selecting 'Zoom in on model' does not work since I went to Octoprint v1.1.1-32-gd974ab0

@foosel

This comment has been minimized.

Copy link
Owner

commented May 4, 2015

@eboston @cscott I just tested against current devel as well as the version reported in the original ticket. I can't reproduce it. Can you give me any more info? E.g. does it always happen or only with some models, some file sizes etc? Any pattern at all?

@Grifplex only one issue per ticket please.

@eboston

This comment has been minimized.

Copy link
Author

commented May 4, 2015

@foosel Not sure why you can't reproduce it as I can consistently on all PC browsers and Android Chrome and Dolphin. What size is the file you are trying it with? How much RAM is in your system? I can send you a gcode file this happens to me with when I get home tonight.

@eboston

This comment has been minimized.

Copy link
Author

commented May 4, 2015

As for file size, it happens with files > 20mb.

@foosel

This comment has been minimized.

Copy link
Owner

commented May 4, 2015

I tried by setting the threshold for this message down from 20MB to 1MB, then tried loading a 9.5MB file. No issue. So maybe it's caused not by the actual mechanism in place but rather indeed by file size. A test file would help, thanks in advance.

@eboston

This comment has been minimized.

Copy link
Author

commented May 4, 2015

@foosel I sent you an email with a link to a file that causes the problem on my system. It is 22.7MB as reported by OctoPrint when loaded. Just for reference. Running OctoPi which has OctoPrint Version: 1.2.0-dev-758-g2ce40c4-dirty (devel branch). I am using a Raspberry Pi 2 Model B+ (newest version). My PC is running 64 bit Windows 7 Home Premium SP1 with 8GB or RAM.

@foosel

This comment has been minimized.

Copy link
Owner

commented May 5, 2015

@eboston hm, mail hasn't made an appearance yet (also looked into the spam folder) :( can you upload it somewhere (drive, box, dropbox, anything like that) and post the link?

@eboston

This comment has been minimized.

Copy link
Author

commented May 5, 2015

It was a link to a Dropbox file. I hate posting it publicly, but here it is again...

https://www.dropbox.com/s/94ppp8xqb9hckvk/Legs.gcode?dl=0

@foosel

This comment has been minimized.

Copy link
Owner

commented May 5, 2015

Ok, just downloaded it and now I have it, you can delete it so it doesn't stay public longer

@foosel

This comment has been minimized.

Copy link
Owner

commented May 5, 2015

Hm... I still can't reproduce it. Will try from a Pi (although since it's client side it shouldn't actually make a difference, but if it's some odd network problem...)

@foosel

This comment has been minimized.

Copy link
Owner

commented May 5, 2015

Good news, on the Pi it is reproducible

foosel added a commit that referenced this issue May 5, 2015

Fix: Only show the "too big" dialog in the gcode viewer if no file lo…
…ading is currently taking place

Possible fix for #825
@foosel

This comment has been minimized.

Copy link
Owner

commented May 5, 2015

Possible fix committed, can you verify?

@eboston

This comment has been minimized.

Copy link
Author

commented May 5, 2015

I'll update tonight after work.

@foosel

This comment has been minimized.

Copy link
Owner

commented May 5, 2015

Awesome, thanks

@eboston

This comment has been minimized.

Copy link
Author

commented May 5, 2015

Pulled the current version and verified that it is working now. It actually generated the view for that file which it has never done before.

@foosel

This comment has been minimized.

Copy link
Owner

commented May 6, 2015

Perfect, closing then!

@foosel foosel closed this May 6, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.