-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GCode Viewer Size Override Not Working #825
Comments
I'm seeing this, too. |
@foosel Not sure why you can't reproduce it as I can consistently on all PC browsers and Android Chrome and Dolphin. What size is the file you are trying it with? How much RAM is in your system? I can send you a gcode file this happens to me with when I get home tonight. |
As for file size, it happens with files > 20mb. |
I tried by setting the threshold for this message down from 20MB to 1MB, then tried loading a 9.5MB file. No issue. So maybe it's caused not by the actual mechanism in place but rather indeed by file size. A test file would help, thanks in advance. |
@foosel I sent you an email with a link to a file that causes the problem on my system. It is 22.7MB as reported by OctoPrint when loaded. Just for reference. Running OctoPi which has OctoPrint Version: 1.2.0-dev-758-g2ce40c4-dirty (devel branch). I am using a Raspberry Pi 2 Model B+ (newest version). My PC is running 64 bit Windows 7 Home Premium SP1 with 8GB or RAM. |
@eboston hm, mail hasn't made an appearance yet (also looked into the spam folder) :( can you upload it somewhere (drive, box, dropbox, anything like that) and post the link? |
It was a link to a Dropbox file. I hate posting it publicly, but here it is again... |
Ok, just downloaded it and now I have it, you can delete it so it doesn't stay public longer |
Hm... I still can't reproduce it. Will try from a Pi (although since it's client side it shouldn't actually make a difference, but if it's some odd network problem...) |
Good news, on the Pi it is reproducible |
…ading is currently taking place Possible fix for #825
Possible fix committed, can you verify? |
I'll update tonight after work. |
Awesome, thanks |
Pulled the current version and verified that it is working now. It actually generated the view for that file which it has never done before. |
Perfect, closing then! |
Selecting GCode Viewer tab with a large print file.
After getting the warning about the file size and clicking the visualize regardless of size button, for the GCode Viewer to show the visualization. Either that or for the browser to lock-up as stated in the warning.
The blank visualization screen is shown then it goes back to the warning message.
Version: 1.2.0-dev-668-g3ebd54d (devel branch)
(if applicable - always include if unsure):
Printrbot Simple Metal
System running Browser (if applicable - always
include if unsure):
Chrome v41.0.2272.101 m
Nothing was shown in the log
gist.github.com or pastebin.com (if applicable - always
include if unsure or reporting communication issues):
Nothing shown in the terminal tab
on gist.github.com or pastebin.com or alternatively a
screenshot (if applicable - always include if unsure
or reporting UI issues):
No errors were displayed in the javascript console.
include if unsure or reporting UI issues):
N/A
I have read the FAQ.
This same behavior is seen on my mobile devices and desktop browsers.
The text was updated successfully, but these errors were encountered: